Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with discord encoding #1702

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix issue with discord encoding #1702

merged 1 commit into from
May 31, 2022

Conversation

Licenser
Copy link
Member

Pull request

Description

Fix issue with id encoding in the discord connector. ids were encoded as snowflake-strings but expected to be decoded as u64.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1702 (8a0a15b) into main (ad8c32a) will increase coverage by 31.29%.
The diff coverage is 83.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1702       +/-   ##
===========================================
+ Coverage   56.53%   87.82%   +31.29%     
===========================================
  Files         243      254       +11     
  Lines       37005    50432    +13427     
===========================================
+ Hits        20920    44291    +23371     
+ Misses      16085     6141     -9944     
Flag Coverage Δ
clicommand 14.45% <0.00%> (-0.01%) ⬇️
cliintegration 52.82% <0.00%> (+0.01%) ⬆️
cliunit 13.40% <0.00%> (-0.01%) ⬇️
unittests 86.44% <83.95%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/discord/handler.rs 0.00% <0.00%> (ø)
src/connectors/impls/discord/utils.rs 98.91% <100.00%> (+98.91%) ⬆️
tremor-script/src/std_lib/system.rs 92.85% <0.00%> (-7.15%) ⬇️
src/connectors/impls/otel.rs 96.96% <0.00%> (-3.04%) ⬇️
src/errors.rs 80.85% <0.00%> (-1.29%) ⬇️
tremor-script/src/ast/visitors.rs 99.28% <0.00%> (-0.72%) ⬇️
tremor-cli/src/test/before.rs 77.64% <0.00%> (-0.59%) ⬇️
src/lib.rs 100.00% <0.00%> (ø)
src/version.rs 100.00% <0.00%> (ø)
tremor-script/src/lib.rs 100.00% <0.00%> (ø)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad8c32a...8a0a15b. Read the comment docs.

@Licenser Licenser enabled auto-merge (rebase) May 31, 2022 05:10
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The early bird catches the worm!

@Licenser Licenser merged commit 8647ace into main May 31, 2022
@Licenser Licenser deleted the fix-discord-encoding branch May 31, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants