New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds syslog codec #856
Merged
Merged
Adds syslog codec #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murex971
requested review from
anupdhml,
darach,
Licenser and
mfelsche
as code owners
March 19, 2021 13:51
murex971
force-pushed
the
syslog-codec
branch
2 times, most recently
from
March 27, 2021 09:46
740faf7
to
a0e0329
Compare
murex971
force-pushed
the
syslog-codec
branch
2 times, most recently
from
March 31, 2021 17:48
f7370e8
to
f6526c2
Compare
Licenser
reviewed
Apr 12, 2021
Licenser
reviewed
Apr 12, 2021
Licenser
reviewed
Apr 13, 2021
// Function used to resolve the year for syslog messages that don't include the year. | ||
// If the current month is January, and the syslog message is for December, it will take the previous year. | ||
// Otherwise, take the current year. | ||
fn resolve_year((month, _date, _hour, _min, _sec): IncompleteDate) -> i32 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it make sense to return the previous year for all month that are larger then the current month?
Licenser
previously approved these changes
Apr 13, 2021
Signed-off-by: murex971 <nupur202000@gmail.com>
mfelsche
approved these changes
Apr 14, 2021
@murex971 I am going ahead and merge this! 🎉 🎈 🚀 |
Wooohhhh! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: murex971 nupur202000@gmail.com
Pull request
Description
Related
Checklist