Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds syslog codec #856

Merged
merged 2 commits into from Apr 15, 2021
Merged

Adds syslog codec #856

merged 2 commits into from Apr 15, 2021

Conversation

murex971
Copy link
Contributor

@murex971 murex971 commented Mar 19, 2021

Signed-off-by: murex971 nupur202000@gmail.com

Pull request

Description

  • receive syslog data via UDP (onramp) and turn syslog messages into structured events.
  • turn structured events into textual syslog messages

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

@murex971 murex971 force-pushed the syslog-codec branch 2 times, most recently from 740faf7 to a0e0329 Compare March 27, 2021 09:46
@murex971 murex971 force-pushed the syslog-codec branch 2 times, most recently from f7370e8 to f6526c2 Compare March 31, 2021 17:48
@coveralls
Copy link
Collaborator

coveralls commented Apr 6, 2021

Coverage Status

Coverage increased (+0.04%) to 83.431% when pulling e376276 on murex971:syslog-codec into 800cb3b on tremor-rs:main.

src/codec/syslog.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
// Function used to resolve the year for syslog messages that don't include the year.
// If the current month is January, and the syslog message is for December, it will take the previous year.
// Otherwise, take the current year.
fn resolve_year((month, _date, _hour, _min, _sec): IncompleteDate) -> i32 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it make sense to return the previous year for all month that are larger then the current month?

Licenser
Licenser previously approved these changes Apr 13, 2021
Signed-off-by: murex971 <nupur202000@gmail.com>
@mfelsche
Copy link
Member

@murex971 I am going ahead and merge this! 🎉 🎈 🚀

@mfelsche mfelsche merged commit 7a1e91a into tremor-rs:main Apr 15, 2021
@Licenser
Copy link
Member

Wooohhhh! :D

@murex971 murex971 deleted the syslog-codec branch April 15, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants