New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept [X] as marked task #328
Conversation
I'm a developer at @CCExtractor and we will be using this project to send markdown to html emails in our CI system. ### The Issue Github supports using either `[x]` or `[X]` in marking task list item. Unfortunately, markdown2 only converts `[x]` to checked list. ### The Fix I've changed the regex to accept [X] in the tasklist marked regex subgroup and consequently, we check using a conditional block.
Looks good to me, thanks! Can you modify the task list test to also use the uppercase X? |
@nicholasserra Done. Please merge this ASAP so that we can update our version. |
@nicholasserra How much time would it take for the PyPI hosted package to update from here? I would like to update our server installed markdown-2 with the latest changes. |
I'll try to get an update out within the next couple days |
Thanks a lot. I would highly appreciate if you can give me an update (preferably in this thread or somewhere I can subscribe) once you've done the PyPI deployment. |
2.3.8 has been released to pypi |
Thanks a lot for the update.
…On Thu 30 May, 2019, 00:27 Nicholas Serra, ***@***.***> wrote:
2.3.8 has been released to pypi
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#328?email_source=notifications&email_token=AH2K2IHEXD7YETUNTQCV6SDPX3GYHA5CNFSM4HPVJ6DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQKEEI#issuecomment-497066513>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH2K2IHFCQERNNQBH5NURLDPX3GYHANCNFSM4HPVJ6DA>
.
|
I'm a developer at @CCExtractor and we will be using this project to send markdown to html emails in our CI system.
The Issue
Github supports using either
[x]
or[X]
in marking task list item. Unfortunately, markdown2 only converts[x]
to checked list.e.g.
The Fix
I've changed the regex to accept [X] in the tasklist marked regex subgroup and consequently, we check using a conditional block.