Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquotes: Don't merge sequential quotes into a single blockquote #356



Copy link

This fixes the bug reported in #332, where two sequential quotes with whitespace between them get converted to a single blockquote.

The culprit is a whitespace matcher in the regex; I'm not sure what case it is intended to address. All tests pass without it (and I added a new one to demonstrate this issue and fix).

Blockquotes containing internal lines also seem fine, I added a test just to be sure. n.b. It is leaving some spaces (note the ..\n), which I included in the test; that seems like a separate bug. Not introduced in this PR.


@codebykat codebykat changed the title Blockquotes: Don't mash up sequential quotes into a single blockquote Blockquotes: Don't merge sequential quotes into a single blockquote Jun 12, 2020
Copy link

nicholasserra commented Jun 12, 2020

Thanks! I'll check this out ASAP. Definitely odd that the regex line is there and has a comment for its purpose, but doesn't seem to fail any tests without. A bit worrisome, but i'll take a good look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants