Blockquotes: Don't merge sequential quotes into a single blockquote #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes the bug reported in #332, where two sequential quotes with whitespace between them get converted to a single blockquote.
The culprit is a whitespace matcher in the regex; I'm not sure what case it is intended to address. All tests pass without it (and I added a new one to demonstrate this issue and fix).
Blockquotes containing internal lines also seem fine, I added a test just to be sure. n.b. It is leaving some spaces (note the
..\n
), which I included in the test; that seems like a separate bug. Not introduced in this PR.