-
Notifications
You must be signed in to change notification settings - Fork 3
Update Trento support plugin content #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abravosuse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I view the file incorporating the changes, headers and prompts are rendered literally rather than being replaced with the right values. But I don't know if this is because the file in the PR is missing the corresponding variable sources or because it's a syntax issue. If it is the former, then I approve the PR AS-IS. But if it is the latter, then changes are necessary.
|
Hey @abravosuse sadly it is normal for the preview on GitHub to not render variables when they are included in an extra file, like in these changes: These variables are rendered properly during build: If you want to preview or review locally the docs then follow this simple guide: Just don't forget to checkout the current branch in step 1 --> 1. Clone the Repository, in this case it would be If you have questions or need help with how preview locally the changes please let me know. |
|
Thanks for the clarification, @EMaksy . And for sharing the output after build. It looks great. Sadly I don't have a proper dev set up in my laptop but I'll see if I can follow those instructions using Leap. |
| trento-server-web-* | ||
| trento-server-wanda-* | ||
| {prompt_user}kubectl get pods | ||
| trento-server-prometheus-server-\* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about this line break is it expected output ?
As far as i know, https://kubernetes.io/docs/tutorials/kubernetes-basics/explore/explore-intro/#check-application-configuration the command list all pods, so this is the example output ?
@abravosuse can you confirm ?
@dmpop what do you think ?
67ac4c4 to
5e4cbc1
Compare
* Fix TRNT-3895 * Add feedback
* Fix TRNT-3895 * Add feedback

Update Trento support plugin content