Skip to content

Conversation

@dmpop
Copy link
Collaborator

@dmpop dmpop commented Oct 27, 2025

Update Trento support plugin content

@dmpop dmpop requested review from EMaksy and abravosuse October 27, 2025 11:33
@dmpop dmpop changed the title Fix TRNT-3895 Update Trento support plugin content Oct 27, 2025
Copy link
Collaborator

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I view the file incorporating the changes, headers and prompts are rendered literally rather than being replaced with the right values. But I don't know if this is because the file in the PR is missing the corresponding variable sources or because it's a syntax issue. If it is the former, then I approve the PR AS-IS. But if it is the latter, then changes are necessary.

@EMaksy
Copy link
Member

EMaksy commented Oct 27, 2025

Hey @abravosuse sadly it is normal for the preview on GitHub to not render variables when they are included in an extra file, like in these changes:
https://github.com/trento-project/docs/pull/101/files#diff-506dc4eb0f71509c1b6eaf83215a0071b513493908cd28820cb0f5badb874ff1R1

These variables are rendered properly during build:
image

If you want to preview or review locally the docs then follow this simple guide:
https://www.trento-project.io/docs/developer/trento-docs-site/README.html#_1_clone_the_repository

Just don't forget to checkout the current branch in step 1 --> 1. Clone the Repository, in this case it would be
gh pr checkout 101

If you have questions or need help with how preview locally the changes please let me know.

@abravosuse
Copy link
Collaborator

Thanks for the clarification, @EMaksy . And for sharing the output after build. It looks great. Sadly I don't have a proper dev set up in my laptop but I'll see if I can follow those instructions using Leap.

@abravosuse abravosuse self-requested a review October 28, 2025 09:00
trento-server-web-*
trento-server-wanda-*
{prompt_user}kubectl get pods
trento-server-prometheus-server-\*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about this line break is it expected output ?

As far as i know, https://kubernetes.io/docs/tutorials/kubernetes-basics/explore/explore-intro/#check-application-configuration the command list all pods, so this is the example output ?

@abravosuse can you confirm ?

@dmpop what do you think ?

@dmpop dmpop force-pushed the update-support-plugin branch from 67ac4c4 to 5e4cbc1 Compare October 30, 2025 13:05
@dmpop dmpop merged commit 0cce42a into main Oct 30, 2025
5 checks passed
@dmpop dmpop deleted the update-support-plugin branch October 30, 2025 13:07
nelsonkopliku pushed a commit that referenced this pull request Oct 31, 2025
* Fix TRNT-3895

* Add feedback
EMaksy pushed a commit that referenced this pull request Nov 28, 2025
* Fix TRNT-3895

* Add feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants