Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd word wrap feature #12
Conversation
|
@trestletech -- I'm sure you're swamped with more important things. I'm just curious if you intend to merge this, since that will determine if I use the word wrap feature in my shiny app. Thanks! |
|
Hey! Sorry it took a bit to get back to you. This looks great; thanks for adding it. I see just a couple of things that we'd need to add before I merge:
If you have a chance to do these, I'd be happy to merge. If not, I'll try to find some time to do it, but it might not be this week. Ultimately I'd definitely be happy to put this feature in, though. |
Closes #12. Merge branch 'master' of github.com:ncarchedi/shinyAce into feature/word-wrap Conflicts: R/ace-editor.R
|
@trestletech Thanks for the merge! Sorry I was slow to respond. I actually hacked together a solution yesterday on the JS side of things, but yours is way more elegant. I never thanked you for putting shinyAce together in the first place. It's EXTREMELY useful for the project I'm working on. Cheers, |
Hi Jeff:
I'm using shinyAce for a project of mine and word wrapping would really be useful. I don't know a lick of javascript, but I was able to hack this together based on your existing code and the ace how-to guide. It seems to work well on my Mac.
Please note that I haven't updated any documentation, since I'm running roxygen2 v4.0.0 and I can't seem to prevent it from rewriting all of your docs.
Comments/criticism welcome.
Cheers,
Nick