Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Completion for R #21

Merged
merged 2 commits into from Dec 1, 2014
Merged

Conversation

@saurfang
Copy link
Contributor

@saurfang saurfang commented Nov 24, 2014

Hi Jeff:

Here is my first attempt for #20. I had to upgrade ace library to 1.1.8 for some new features related to auto completion. I took the library from https://github.com/ajaxorg/ace-builds/tree/v1.1.8/src-min-noconflict. Hope this is okay for you.

For a quick summary, I have:

  1. Updated aceEditor to take autoComplete to enable/disable code completion and autoCompleteList to take list of static code completion candidates. Again the latter is very useful for NSE functions as you can try in the demo below.
  2. Updated updateAceEditor to allow enable/disable autocomplete and update static completion list.
  3. Added aceAutocomplete to invoke utils:::.win32consoleCompletion which delivers the same code completions experience as R console.

The demo included in examples can be seen at: https://saurfang.shinyapps.io/shinyAceAutocomplete/

You can review this commit for all my code changes: saurfang@84d45db

Can you take a look and let me know if you have any questions or suggestions?

@trestletech trestletech merged commit 84d45db into trestletech:master Dec 1, 2014
@trestletech
Copy link
Owner

@trestletech trestletech commented Dec 1, 2014

This is really great stuff. Thanks for contributing.

I added you to the contributors list: https://github.com/trestletech/shinyAce#contributors-in-order-of-first-commit . Let me know if there's another URL you'd rather I link to.

Bumped to v0.2.0 with this feature. I'll let this soak on GitHub for a bit then push to CRAN.

@saurfang
Copy link
Contributor Author

@saurfang saurfang commented Dec 4, 2014

That looks great. Thanks a lot for taking my PR. I definitely like waiting for a bit to tease out any potential bugs.

@krdeepakio
Copy link

@krdeepakio krdeepakio commented Oct 8, 2015

Is this feature live on CRAN or we need to get the package from github to use autocomplete?

@sjmgarnier
Copy link

@sjmgarnier sjmgarnier commented Oct 8, 2015

@krdeepakio ShinyAce is still in version 0.1.0 on CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.