Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP][Completion] Configurable Completers #53
Merged
Conversation
Improve configurability of completers: 1. Completers can be selectively enabled and disabled. `snippet` and `keywords` completers source completions from Ace's language mode definition. `text` completer completes with local words. 1. R language completer now receives full text in addition to the current line buffer due to full text lags due to debouncing. 1. R language completer now provides full completion object such that fields can be customized: name, value, description and meta.
|
For the yaml processing example I mentioned |
|
@saurfang and @GregorDeCillia: I ended up using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Improve reconfigurability of completers:
snippetandkeywordscompleters source completions from Ace's language mode definition.textcompleter completes with local words.@vnijs This is based on my work in progress SQL editor. As far as I can tell, it works fine but I have not done extensive testing. Feel free to work off of this branch or even merge if you wish. I have left a few TODOs in the code for ideas.
For your case, I think you need
and with
value <- session$input[[paste0("shinyAce_", inputId, "_hint")]]you can get full document withvalue$documentto parse yaml with.p.s. The js injection in
aceEditorhorrifies me a little and it's also unfortunate to have a duplicated logic inaceEditorandupdateAceEditor.