New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LSynth parts to LPub3D archive #165

Closed
trevorsandy opened this Issue Dec 5, 2018 · 1 comment

Comments

1 participant
@trevorsandy
Copy link
Owner

trevorsandy commented Dec 5, 2018

Subject

Automatically load LPub3D LSynth parts.

Environment

Version of LPub3D - 2.3.3
Operating system - All

Expected behaviour

Add LSynth parts to LPub3D archive with one click.
Also add LSynth parts to LDraw search directories with one click, enabling parts access to the LPub3D renderers.

Actual behaviour

Current behaviour requires the user to manually add the parts to a subfolder under unofficial
parts and add that location to the LPub3D search directories under Preferences.

Solution

This enhancement adds LSynth parts to the LPub3D application resource bundle.

If the user has already installed the LSynth parts under his/her LDraw disk library ‘parts’ location, the Preferences checkbox 'Archive LSynth Parts' adds the flag to allow the user to automatically add LSynth parts to the LPub3D archive file. This allows LPub3D to validate LSynth parts in the model file without having to create and add an external LSynth path to the LPub3D search directories. Because LDraw ‘parts’ and ‘p’ subfolders are excluded from the list of LPub3D search directories as they are already archived, ‘user added’ parts at these locations are not added to the archive.

In the event LSynth parts are not currently installed, a second Preferences checkbox 'Add LSynth Search Directory' adds the flag to allow the user to create and add the LSynth path to the search directories. In addition to being added to the LPub3D archive, the resource bundled LSynth parts are also extracted to the created path, enabling parts access to the LPub3D renderers.

@trevorsandy trevorsandy self-assigned this Dec 5, 2018

@trevorsandy

This comment has been minimized.

Copy link
Owner

trevorsandy commented Dec 5, 2018

Implemented.

image

Cheers,

@trevorsandy trevorsandy added this to the 2.3.4 milestone Dec 5, 2018

@trevorsandy trevorsandy closed this Dec 5, 2018

@trevorsandy trevorsandy added this to DONE in LPub3D Maintenance via automation Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment