New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add image of sub-model before the first step #52

Closed
lattam opened this Issue Apr 11, 2018 · 15 comments

Comments

4 participants
@lattam
Copy link

lattam commented Apr 11, 2018

Hi,
thank you for this amazing project! I have one proposal for another feature which is common in many LEGO instructions. The big models often consist of several sub-models and when you start to build any of those sub-models, it is nice to have an overall picture of that sub-model at the beginning of assembly (just before the first step).
I didn't manage to achieve this using the current tools.

Thank you for considering!

@trevorsandy trevorsandy self-assigned this Apr 11, 2018

@trevorsandy

This comment has been minimized.

Copy link
Owner

trevorsandy commented Apr 11, 2018

This is a nice feature. I'll add it to the list for LPub3DNext.

You can achieve this functionality by generating the steps that make up the model; then saving the final model image (perhaps with a different name); then consuming the image as a picture (insert picture) in a subsequent generation pass. You can move pictures around, or place the image on its own page, this approach is flexible.

Cheers,

@lattam

This comment has been minimized.

Copy link

lattam commented Apr 12, 2018

Thank you, I didn't know about this workaround. Will definitely try it.

@trevorsandy trevorsandy added feature and removed enhancement labels Aug 5, 2018

@trevorsandy trevorsandy added this to QUEUE in LPub3D Next Aug 5, 2018

@Landcross

This comment has been minimized.

Copy link

Landcross commented Aug 7, 2018

I didn't see this feature request earlier, but I would also love this feature. While the work-around mentioned by Trevor would work in theory, it's not the look I'm after. It's difficult to explain, so let's show an example: https://www.lego.com/biassets/bi/6187733.pdf

See for example page 10 or page 25. The submodel image is positioned relative to the PLI, which would, in the case of the work-around, already be positioned where you want the image to be. If that makes sense...

@jacovandermolen

This comment has been minimized.

Copy link

jacovandermolen commented Sep 17, 2018

Hi Trevor,
Thanks for this update! I start following LPub3D again.
I am curious: is this feature done or in the next version.
How does this work?

@trevorsandy

This comment has been minimized.

Copy link
Owner

trevorsandy commented Sep 17, 2018

Hi Jaco - With pleasure. This feature is not animated in LPub3D at this moment. While I have the framework in place to implement it, there are other features that I plan to bundle at the same time.

Cheers,

@jacovandermolen

This comment has been minimized.

Copy link

jacovandermolen commented Sep 17, 2018

OK great, I'll wait for it then.

@trevorsandy trevorsandy added this to the 2.4.0 milestone Sep 28, 2018

@trevorsandy trevorsandy added this to IN PROGRESS in LPub3D Maintenance Oct 27, 2018

@trevorsandy trevorsandy changed the title [Feature Request] Possibility to add overall image of sub-model before the first step Add image of sub-model before the first step Nov 5, 2018

@trevorsandy trevorsandy modified the milestones: 2.4.0, 2.3.4 Nov 5, 2018

@trevorsandy

This comment has been minimized.

Copy link
Owner

trevorsandy commented Nov 5, 2018

Implemented.

Submodel display globals setup menu
screenshot - 05_11_2018 07_56_13

Extensive options, including options to show main (top) model at first step and show in callout
screenshot - 05_11_2018 10_59_35

Options to change scale, camera angle and rotation
screenshot - 05_11_2018 08_03_31

Default placement is top right of step number (if displayed) or bottom left of page header
screenshot - 05_11_2018 08_11_12

Context menu
screenshot - 05_11_2018 08_12_34

Available for called out submodels including number of instances in callout
screenshot - 05_11_2018 08_15_32

Multi-step page
screenshot - 05_11_2018 08_45_52

Callout context menu
screenshot - 05_11_2018 08_16_26

Show top model option
screenshot - 05_11_2018 11_09_31

Show top model option.
screenshot - 05_11_2018 08_34_24

Cheers,

@trevorsandy trevorsandy closed this Nov 5, 2018

LPub3D Maintenance automation moved this from IN PROGRESS to DONE Nov 5, 2018

LPub3D Next automation moved this from QUEUE to DONE Nov 5, 2018

@trevorsandy trevorsandy changed the title Add image of sub-model before the first step [Feature] Add image of sub-model before the first step Nov 5, 2018

@Landcross

This comment has been minimized.

Copy link

Landcross commented Nov 5, 2018

Nice! :)
Is it also possible to only place them at normal submodels and not at callouts?

@trevorsandy

This comment has been minimized.

Copy link
Owner

trevorsandy commented Nov 5, 2018

Yes, use the 'Hide Submodel' context menu item. I'll add a flag to do that in the next release.

I added a flag to toggle setting the submodel at the first step of a callout.

Cheers,

@jacovandermolen

This comment has been minimized.

Copy link

jacovandermolen commented Nov 5, 2018

Great feature! Can't wait to try it ;-)
Thanks, Tevor.

@jacovandermolen

This comment has been minimized.

Copy link

jacovandermolen commented Dec 20, 2018

The instance count is not right when using a submodel in a buffer exchange, though the buffered instance is ignored.
Placement and relative to seem not entirely correct either.
I will PM a model file to illustrate.

@trevorsandy

This comment has been minimized.

Copy link
Owner

trevorsandy commented Dec 20, 2018

Hi Jaco, thanks for reporting this behaviour.

Question, is this behaviour linked to displaying a submodel at its first step ?

If not, kindly open a new ticket.

Cheers,

@jacovandermolen

This comment has been minimized.

Copy link

jacovandermolen commented Dec 20, 2018

Sorry: solution for correcting instance count is to inline the submodel after the buffer exchange. So that is "solved".

Another problem: Submodel rotation does not seem to have any effect.

@trevorsandy

This comment has been minimized.

Copy link
Owner

trevorsandy commented Dec 20, 2018

Very well, thanks.

Cheers,

@jacovandermolen

This comment has been minimized.

Copy link

jacovandermolen commented Dec 20, 2018

Question, is this behaviour linked to displaying a submodel at its first step ?

Yes, it is.
Rotation only redraws when an entire reset is done or by changing the scale to force a re-render.
Or delete the generated image in ..\LPub3D\submodels manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment