Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
simple-history 2.6.0 generates a migration while 2.5.1 doesn't #512
Describe the bug
Here's how the initial migration looks like:
The only difference I see is how we reference the
Repeat the above with 2.5.1 instead and the last step tells you there are no changes detected
Environment (please complete the following information):
Found the issue @atodorov ! It's this line here https://github.com/treyhunner/django-simple-history/pull/462/files#diff-db0d12c32869d48141bfca2c94659322L203. In adding the deconstruct method to that code, we accidentally got rid of that line. DSH still supports foreign keys to the same object, but we accidentally got rid of support for using
added a commit
Jan 14, 2019
@rossmechanic thank you for the lightning fast reaction!
This WA works for me and doesn't produce any more migrations.
Unfortunately we do have a live version of Kiwi TCMS out there which customers have deployed and are hitting this issue. As we are shipping with pinned dependencies in our Docker image even if you do release a fix there's not much to be done on our end except publishing a new docker image. Sigh.
referenced this issue
Jan 14, 2019
@atodorov sorry about that! That should have been caught in automated tests, but evidently whoever wrote that feature originally didn't test it... I do have a PR up that should be merged by tomorrow, and I've been planning to have a new release by end of week. Sorry for the additional work