This repository was archived by the owner on Nov 23, 2023. It is now read-only.
Fix Signing of Multisig Testnet Transactions#100
Closed
nickfogle wants to merge 1 commit intotrezor:masterfrom
Closed
Fix Signing of Multisig Testnet Transactions#100nickfogle wants to merge 1 commit intotrezor:masterfrom
nickfogle wants to merge 1 commit intotrezor:masterfrom
Conversation
Fixes "Invalid network version" where multisig testnet transactions defaulted to mainnet.
Contributor
|
nice fix! thx |
Author
|
Hi @karel-3d, any idea when this fix might make it to production? We're currently supporting multisig signing on testnet by loading the popup folder with this fix locally and installing a modified chrome extension to whitelist our domain. Do you think it would be faster to just create a PR to get our domain whitelisted rather than waiting for this PR to be merged? Thanks! |
Member
|
@szymonlesisz Please review and merge and deploy to v4 if it's OK |
Member
|
Merged and deployed to https://connect.trezor.io/4/ @nickfogle Could you please test if that works for you? Please reopen if there are outstanding problems. |
Author
|
Thanks @prusnak! I just sent a transaction over testnet and it's working great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the "Invalid network value" error described in #81 (comment).
When using https://connect.trezor.io/4/connect.js and attempting to sign a multisig testnet transaction,
HDNode.fromBase58()isn't passed any network data and defaults to mainnet.