New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coins: Added Bitcoin Private #85

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@csulmone

csulmone commented Mar 12, 2018

No description provided.

@csulmone

This comment has been minimized.

csulmone commented Mar 12, 2018

I followed the example of similar PRs on this project for adding new coins.

This change is accompanied with PR: trezor/python-trezor#234

I have an electrum client that will accompany this release once merged, but would this be the repo to look at in order to integrate into the trezor webapp? https://github.com/satoshilabs/bitcore-deb

@jhoenicke

This comment has been minimized.

Contributor

jhoenicke commented Mar 12, 2018

Why segwit: False? Does BTCP not support Segwit at all? Does that mean that segwit addresses can't claim the coins?

Also I think force_bip143 must be set to true, if it uses the replay protection like BTG and BCH.

Edit: from a first glance on the btcp code there is no BIP143 style signature and no segwit :(.

Edit2: on second look there seems to be segwit without bip143 signatures, i.e., OP_CHECKSIG checks the same old-style hash in witness scripts as in non-segwit scripts.

@csulmone

This comment has been minimized.

csulmone commented Mar 13, 2018

We added a way to claim segwit utxos without full segwit support, but full segwit support will be soft-forked in over the summer and I will submit a new pull request then.

@csulmone

This comment has been minimized.

csulmone commented Mar 13, 2018

Is there a canonical way trezor handles forked coin display and signing? I was thinking about creating a dedicated electrum front end that will display BTC->BTCP (standard and segwit) balances from the fork and support signing and broadcasting. I didn't want to clutter up the default UX if possible.

@jhoenicke

This comment has been minimized.

Contributor

jhoenicke commented Mar 13, 2018

We handled forks by creating a transaction that sends all coins from the Bitcoin address to the new address for the forked coin. But this way you can't use coin selection.

For electrum, I usually create one wallet with the Bitcoin addresses and one with the new addresses and then send manually the coins from one wallet to the other. I'm not sure if adding a fancy UI is worth the effort (a UI to help with this process that allows to see both coins in one wallet). After all, you should just send your coins over to the new wallet and then you can forget about the old addresses.

@csulmone

This comment has been minimized.

csulmone commented Mar 13, 2018

We can work on messaging and a tutorial to make that as clear as possible. It should just be a matter of using an alternate bip44 coin type for the BTC based hardware wallet front end.

@prusnak

This comment has been minimized.

Member

prusnak commented Mar 13, 2018

@csulmone

This comment has been minimized.

csulmone commented Mar 13, 2018

I agree Pavol - we want to use the least disruptive and most tested method possible.

@csulmone

This comment has been minimized.

csulmone commented Mar 14, 2018

Would the next step for integration be a pull request into bitcore-deb?

csulmone and others added some commits Mar 16, 2018

@prusnak

This comment has been minimized.

Member

prusnak commented Apr 23, 2018

I am reworking the definitions and splitting the file coins.json into multiple smaller json files. These will reside in defs/coins, see 8a40c5f

Your coin from this pull request was added in the commit above. Thanks!

@prusnak prusnak closed this Apr 23, 2018

@prusnak

This comment has been minimized.

Member

prusnak commented Apr 23, 2018

I am reworking the definitions and splitting the file coins.json into multiple smaller json files. These will reside in defs/coins, see 8a40c5f

Your coin from this pull request was added in the commit above. Thanks!

@csulmone

This comment has been minimized.

csulmone commented Apr 24, 2018

I am going to be putting together a new version of electrum-btcp that will understand how to spend BTC->BTCP segwit inputs as well as a guide on how to do it. Is this the last holdback to releasing BTCP in the next firmware update?

@csulmone

This comment has been minimized.

csulmone commented Apr 24, 2018

We already have support for segwit BTC input spends on the full-node wallet.

@aramis1987

This comment has been minimized.

aramis1987 commented Apr 25, 2018

Good job Sulmone !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment