Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop U2F counter from Bitcoin-only firmware #709

Closed
matejcik opened this issue Nov 15, 2019 · 3 comments
Closed

Drop U2F counter from Bitcoin-only firmware #709

matejcik opened this issue Nov 15, 2019 · 3 comments
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user T1B1 legacy Trezor One
Projects
Backlog 🗂

Comments

@matejcik
Copy link
Contributor

The u2f functionality is disabled on Bitcoin-only firmware, but the management commands SetU2FCounter and GetNextU2FCounter are still available.

They don't affect much, but they should probably be removed too.
@matejcik matejcik added core Trezor Core firmware. Runs on Trezor Model T and T2B1. T1B1 legacy Trezor One labels Nov 15, 2019
@matejcik
Copy link
Contributor Author

apparently Wallet onboarding sets the U2F counter, so we must investigate whether it's using this call

@prusnak
Copy link
Member

prusnak commented Nov 15, 2019

Also there are u2f_counter fields in ResetDevice, LoadDevice and RecoverDevice messages.

@prusnak prusnak added this to the backlog milestone Feb 19, 2020
@tsusanka tsusanka added the feature Product related issue visible for end user label Oct 29, 2020
@tsusanka tsusanka removed W2 labels Feb 19, 2021
@tsusanka tsusanka moved this from 📥 Inbox to 📽 Product in Firmware · Backlog 🗂 Oct 5, 2021
@tsusanka tsusanka removed this from the backlog milestone Oct 6, 2021
@matejcik matejcik removed the LOW label Oct 7, 2021
@alex-jerechinsky alex-jerechinsky added this to 📽 Product in Backlog 🗂 Oct 22, 2021
@alex-jerechinsky alex-jerechinsky removed this from 📽 Product in Firmware · Backlog 🗂 Oct 22, 2021
@sime sime changed the title Bitcoin-only firmware supports U2F counter Drop U2F counter from Bitcoin-only firmware Feb 21, 2022
@sime sime added the LOW label Feb 21, 2022
@hynek-jina hynek-jina removed the LOW label May 6, 2022
@matejcik
Copy link
Contributor Author

matejcik commented Feb 7, 2023

This does not seem at all important for the foreseeable future.

@matejcik matejcik closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user T1B1 legacy Trezor One
Projects
Firmware
Archived in project
Backlog 🗂
📽 Product
Milestone
No milestone
Development

No branches or pull requests
6 participants
@prusnak @sime @matejcik @tsusanka @hynek-jina @ZdenekSL