Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Hedera #502

Closed
wants to merge 1 commit into from
Closed

Conversation

mehcode
Copy link

@mehcode mehcode commented Sep 5, 2019

Support for three kinds of transactions are implemented for now. Creating a new account, sending hbar (currency), and confirming your account ID.

No tests are added at this time. I'd like to have an initial review and some direction on how and where to add tests if needed.

Please let me know if there are any questions or concerns with the implementation.


A wallet that supports Hedera + Trezor will be made available at http://github.com/hashgraph/myhbarwallet at a later date.


Companion PR for trezor-connect: trezor/connect#449

@mehcode mehcode force-pushed the feature/hedera branch 5 times, most recently from 4c135cc to a817737 Compare Sep 5, 2019
Support for three kinds of transactions are implemented for now. Creating a new account, sending hbar (currency), and confirming your account ID.
@prusnak
Copy link
Member

@prusnak prusnak commented Sep 6, 2019

This coin does not seem relevant enough for addition.

@prusnak prusnak closed this Sep 6, 2019
@kenthejr
Copy link

@kenthejr kenthejr commented Sep 6, 2019

@prusnak Hedera is going into "Open Access" on September 16th, which is when exchanges can start creating accounts for users.

At the same time, there are already thousands of users (15,229 users to be precise: https://hash-hash.info/new) who hold hbars and want to secure their accounts with hardware wallets. We've commissioned @mehcode to build the Trezor integration.

FWIW, I am the Chief Developer Advocate for Hedera and would be happy to answer any questions.

@prusnak
Copy link
Member

@prusnak prusnak commented Sep 6, 2019

Please reopen once your coin is in TOP 30 on Coinmarketcap.

@kenthejr
Copy link

@kenthejr kenthejr commented Sep 6, 2019

@prusnak do you mind if I email you on your listed github email? I have additional information that I think will change the discussion a bit. If we just look that funds raised so far and total supply, we more than meet your requirement, but as you know, CoinMarketCap isn't going to list until hbars have been on exchanges for a bit and I think the opportunity to have a reputable hardware wallet on board before then is strong. I just don't want to use github for that conversation.

@prusnak
Copy link
Member

@prusnak prusnak commented Sep 6, 2019

There is no need to discuss. You might approach us again when your coin is relevant. At the moment it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants