Skip to content
This repository has been archived by the owner. It is now read-only.

WIP mBTC support #292

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@saleemrashid
Copy link
Contributor

saleemrashid commented Jan 20, 2018

Needs Storage field. It could be implemented two ways:

  1. Always use either BTC or mBTC (depending on the user's preference)
  2. Use either BTC or mBTC depending on the value (if the user has enabled this feature)

Fixes #54

const char *suffix;
int decimals;

// TODO: Implement Storage field

This comment has been minimized.

Copy link
@saleemrashid

saleemrashid Jan 20, 2018

Author Contributor

☝️

@saleemrashid

This comment has been minimized.

Copy link
Contributor Author

saleemrashid commented Jan 20, 2018

We could also add another field to CoinInfo to support bits (uBTC), lites (uLTC), atoms (uDCR), etc. and fallback to the prefix u if we don't have a customized name.

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Jan 20, 2018

Option 1 makes much more sense than option 2.

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Jan 20, 2018

Also I would like to have 4 options (BTC, mBTC, uBTC, satoshi), not 2 (BTC, mBTC). First three are easy, not sure about the last one. (Zcash has "zatoshi", Litecoin "litoshi"?)

@saleemrashid

This comment has been minimized.

Copy link
Contributor Author

saleemrashid commented Jan 20, 2018

Not sure about the usefulness of satoshis (especially if we're not changing the units depending on the value).

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Jan 20, 2018

I agree that Satoshi unit is probably not that useful, but it seems that Lightning people love that unit (judging by screenshots of lightning-app).

@prusnak prusnak referenced this pull request Jan 21, 2018

Closed

Display mBTC/bits #54

@prusnak prusnak added this to the 1.6.1 milestone Jan 23, 2018

@prusnak prusnak added the feature label Apr 2, 2018

@prusnak prusnak removed this from the v1.7.0 milestone Oct 3, 2018

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Apr 15, 2019

Let's not merge this. We might switch to satoshis soon :)

@prusnak prusnak closed this Apr 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.