Skip to content
This repository has been archived by the owner. It is now read-only.

Refactor message processing to remove tiny mode stack #374

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
2 participants
@saleemrashid
Copy link
Contributor

saleemrashid commented Jun 25, 2018

Re-use the normal message processing stack for tiny mode.

Depends on https://github.com/saleemrashid/trezor-common/tree/wire-no-fsm

@saleemrashid saleemrashid referenced this pull request Jun 25, 2018

Merged

Add wire_no_fsm #146

@saleemrashid saleemrashid force-pushed the saleemrashid:messages-refactor branch from 51ad1ad to 58a6ce4 Jun 27, 2018

@prusnak prusnak added this to the v1.7.0 milestone Jun 27, 2018

@prusnak prusnak added the enhancement label Jun 27, 2018

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Jul 10, 2018

I merged the changes into trezor-common and cherry picked e61ec5b (as dbb3e92)

I also did some major changes to reflect the nested structure of protobuf messages. If you have time, could you please rebase? Thanks!

@saleemrashid saleemrashid force-pushed the saleemrashid:messages-refactor branch from 58a6ce4 to c7284b8 Jul 10, 2018

@saleemrashid

This comment has been minimized.

Copy link
Contributor Author

saleemrashid commented Jul 10, 2018

@prusnak Rebased. Might want to cherry-pick c7284b8.

@saleemrashid saleemrashid force-pushed the saleemrashid:messages-refactor branch from c7284b8 to 200a0e5 Jul 10, 2018

@saleemrashid

This comment has been minimized.

Copy link
Contributor Author

saleemrashid commented Jul 10, 2018

Never mind, rebased again and you've fixed that in master now

@prusnak prusnak removed this from the v1.7.0 milestone Oct 3, 2018

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Apr 15, 2019

Let's not add this. We are porting trezor-core to T1, which should resolve this issue.

@prusnak prusnak closed this Apr 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.