Skip to content
This repository has been archived by the owner. It is now read-only.

EOS Support #449

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@keepkeyjon
Copy link

commented Jan 28, 2019

Consider this a very rough cut at adding EOS support. I've still got lots of cleaning up to do, and haven't tested it at all. That said, I'd appreciate early feedback, particularly on my use of layoutDialogSwipe()... it's a bit less easy to use than our confirm().

keepkeyjon added some commits Jan 27, 2019

sender,
_("to"),
receiver);
if (!protectButton(ButtonRequestType_ButtonRequest_ConfirmOutput, false)) {

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

In our port, I called this button request ConfirmAction. What would you prefer here? It seems unfriendly to clients to call everything ConfirmOutput...

#include <stdio.h>
#include <time.h>

Hasher hasher_preimage;

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

In ours I marked these CONFIDENTIAL out of an abundance of caution. When I do that here, the section ends up too big.

@@ -128,3 +132,6 @@ bl_data.h: bl_data.py ../bootloader/bootloader.bin
clean::
rm -f bl_data.h
find -maxdepth 1 -name "*.mako" | sed 's/.mako$$//' | xargs rm -f

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

Note to self: delete stray whitespace.

@@ -0,0 +1,476 @@
#include "eos.h"

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

What license header should I put on the new files?

return true;
}

bool eos_compileActionNewAccount(const EosActionCommon *common,

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

Note to self: add back the SLIP48 stuff.

if (fsm_layoutAddress(resp->wif_public_key, "EOS Pubkey", false, 0,
msg->address_n, msg->address_n_count, false)) {
fsm_sendFailure(FailureType_Failure_ActionCancelled,
"Show EOS public key cancelled.");

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

missing _()s

case EOS_LinkAuth:
case EOS_UnlinkAuth:
return true;
}

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

Note to self: add __builtin_unreachable() to force enum additions to also be added to the switch.

const size_t prefix_len = strlen(prefix);
strlcpy(pubkey, prefix, len);

if (!base58_encode_check(public_key, 33, HASHER_SHA2, // FIXME: HASHER_RIPEMD,

This comment has been minimized.

Copy link
@keepkeyjon

keepkeyjon Jan 28, 2019

Author

Reminds me I need to make a patch for trezor-crypto.

@keepkeyjon

This comment has been minimized.

Copy link
Author

commented Jan 28, 2019

@prusnak

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

We won't be adding EOS to trezor-mcu in the end. We will add EOS to Trezor One by porting Trezor Core to Trezor One.

@prusnak prusnak closed this Mar 26, 2019

@keepkeyjon

This comment has been minimized.

Copy link
Author

commented Mar 26, 2019

ok

@matejcik matejcik referenced this pull request Apr 11, 2019

Closed

EOS Support #265

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.