Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noxonix protocol generation #650

Open
ardunn opened this issue Aug 12, 2022 · 1 comment
Open

Noxonix protocol generation #650

ardunn opened this issue Aug 12, 2022 · 1 comment
Assignees
Labels

Comments

@ardunn
Copy link
Collaborator

ardunn commented Aug 12, 2022

Do for protocol the same thing that BEEPDatapath does for cycler runs; a consistent interface with simple(r) access to the underlying objects. First try this approach on the Novonix protocol generation since it is the most accessible at the moment.

i.e., NovonixProtocol would inherit Protocol and would be used like

np = NovonixProtocol.from_parameter_file("protocol_parameter_file")

# edit protocol steps
np.edit_step("cv_hold_charge", 3)

# write the file
np.to_file(filepath_for_protocol_file)
@ardunn ardunn added bug Something isn't working featurization priority and removed bug Something isn't working featurization labels Aug 12, 2022
@ardunn ardunn self-assigned this Aug 12, 2022
@ardunn
Copy link
Collaborator Author

ardunn commented Aug 12, 2022

@shijingsun-TRI if Xiao posts the code for the current novonix protocol generation I could start looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant