Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Simple Request methods #27

Closed
moonglum opened this Issue · 4 comments

1 participant

@moonglum
Owner

While I refactored the Query Class (af72aeb) some interesting helper methods emerged:

  • allowed_options
  • prepare_request_data
  • simple_query_request
  • put_request
  • post_request

They are all defined as private methods on Query. But they all belong in the Connection class. They will be moved there. This requires almost no afford on the implementation side. But it needs some rearranging of specs. get_request and delete_request should be added, too. Then other classes can benefit from this change, too.

@moonglum moonglum was assigned
@moonglum
Owner

The more I think about it, the more I suspect they belong to the Database class. They need to know about the Cursor Class, and the Connection should not know about that.

@moonglum
Owner

...and simple_query_request belongs to the Collection class.

@moonglum
Owner

I played around with this. But I'm not sure yet. I don't want to include it in the next release.

@moonglum
Owner

Refactored.

@moonglum moonglum closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.