Skip to content

Commit

Permalink
Fix broken "BI boxes" layout toggling
Browse files Browse the repository at this point in the history
CMK-1628

Change-Id: I11413787c5a463f0e6e51ac1aabcb65bc5c4b8b2
  • Loading branch information
LarsMichelsen committed Jun 4, 2019
1 parent 8af32b7 commit 8fa8b4a
Showing 1 changed file with 13 additions and 6 deletions.
19 changes: 13 additions & 6 deletions cmk/gui/bi.py
Expand Up @@ -2643,9 +2643,21 @@ def ajax_render_tree():
reqhosts = [tuple(sitehost.split('#')) for sitehost in html.request.var("reqhosts").split(',')]
aggr_title = html.get_unicode_input("title")
omit_root = bool(html.request.var("omit_root"))
boxes = bool(html.request.var("boxes"))
only_problems = bool(html.request.var("only_problems"))

# TODO: Cleanup the renderer to use a class registry for lookup
renderer_class_name = html.request.var("renderer")
if renderer_class_name == "FoldableTreeRendererTree":
renderer_cls = FoldableTreeRendererTree
elif renderer_class_name == "FoldableTreeRendererBoxes":
renderer_cls = FoldableTreeRendererBoxes
elif renderer_class_name == "FoldableTreeRendererBottomUp":
renderer_cls = FoldableTreeRendererBottomUp
elif renderer_class_name == "FoldableTreeRendererTopDown":
renderer_cls = FoldableTreeRendererTopDown
else:
raise NotImplementedError()

# Make sure that BI aggregates are available
if config.bi_precompile_on_demand:
compile_forest(only_hosts=reqhosts, only_groups=[aggr_group])
Expand All @@ -2669,11 +2681,6 @@ def ajax_render_tree():
continue # Not yet monitored, aggregation is not displayed
row["aggr_group"] = aggr_group

if boxes:
renderer_cls = FoldableTreeRendererBoxes
else:
renderer_cls = FoldableTreeRendererTree

# ZUTUN: omit_root, boxes, only_problems has HTML-Variablen
renderer = renderer_cls(
row,
Expand Down

0 comments on commit 8fa8b4a

Please sign in to comment.