Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to GitHub Actions #1279

Open
11 of 12 tasks
qstokkink opened this issue Mar 5, 2024 · 5 comments
Open
11 of 12 tasks

Move tests to GitHub Actions #1279

qstokkink opened this issue Mar 5, 2024 · 5 comments
Labels
priority: low Should be addressed at some point in the future

Comments

@qstokkink
Copy link
Collaborator

qstokkink commented Mar 5, 2024

We've had several PR test outages due to Jenkins updates over the last few months.

Depending on the outage, the resolution to these outages took me from a few minutes up to multiple days.

It's probably a better use of my/our time to port our jobs to GitHub Actions. The following PR tests would need to be ported:

Additionally, we may want to port the three remaining validation checks (the cross-env check is already in GitHub Actions):

The post-merge tests still seem to be working reliably (Mutation tests + Linux, Mac, Windows coverage listed in the README). Perhaps we should port these at a later date. If we do end up porting these, it concerns the following jobs (we don't really care about the Python versions here):

@qstokkink qstokkink added the priority: medium Enhancements, features or exotic bugs label Mar 5, 2024
@qstokkink
Copy link
Collaborator Author

Side note: this issue only covers tests due to (proposed) merges. Our network health jobs (peer discovery health, default community peer discovery health, and bootstrap connectivity) would remain on Jenkins.

@qstokkink
Copy link
Collaborator Author

We got to the "very very very last thing" a lot sooner than I expected. However, there are some issues with resolving this last bullet point. I'll scale down this issue to low priority.

@qstokkink qstokkink added priority: low Should be addressed at some point in the future and removed priority: medium Enhancements, features or exotic bugs labels Mar 13, 2024
@qstokkink
Copy link
Collaborator Author

Apparently the MutPy changes are not lost at all. https://github.com/Tribler/py-ipv8-mutation-libraries/issues/1#issue-771999920 In that case, we can clean everything up neatly.

@qstokkink
Copy link
Collaborator Author

Once Tribler/mutpy#1 is resolved, this repo should make use of the sanitized fork. Then the approach of #1254 (comment) could be followed to implement the GitHub Action.

@qstokkink
Copy link
Collaborator Author

The mutpy fork issue has now been resolved. An .md report can be generated with:

bin/github_report.py --codebase ipv8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Should be addressed at some point in the future
Development

No branches or pull requests

1 participant