Skip to content

Ryunosuke Sato
tricknotes

Developer Program Member

Organizations

@enishitech @idobata @emberjs @sapporojs @croonga @chuork @babel
Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#526
@tricknotes

Is serial relationship required at index?

tricknotes deleted branch fix-scope-name at bm-sms/daimon-news
Jun 23, 2016
Jun 23, 2016
@tricknotes
Jun 23, 2016
tricknotes merged pull request bm-sms/daimon-news#556
@tricknotes
Fix scope name to improve English
2 commits with 14 additions and 14 deletions
Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#556
@tricknotes

Awesome thnaks!

tricknotes deleted branch remove-to-param-again at bm-sms/daimon-news
Jun 23, 2016
Jun 23, 2016
@tricknotes
Jun 23, 2016
tricknotes merged pull request bm-sms/daimon-news#550
@tricknotes
Remove `Post#to_param` again
5 commits with 225 additions and 36 deletions
Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#550
@tricknotes

🚀

tricknotes deleted branch name-order-specification at bm-sms/daimon-news
Jun 23, 2016
Jun 23, 2016
@tricknotes
Jun 23, 2016
tricknotes merged pull request bm-sms/daimon-news#554
@tricknotes
Name order specification as scope for serials
1 commit with 2 additions and 1 deletion
Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#554
@tricknotes

🙆

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#550
@tricknotes

Rails.root.join("db/data/thumbnail.jpg").open

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#550
@tricknotes

You can use Pathname#open to open a file (not a URL) explicitly.

tricknotes deleted branch serials-page-title at bm-sms/daimon-news
Jun 23, 2016
Jun 23, 2016
@tricknotes
Jun 23, 2016
tricknotes merged pull request bm-sms/daimon-news#551
@tricknotes
Add page entries info to serials page title to distinguish titles
3 commits with 22 additions and 1 deletion
Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#551
@tricknotes

Look awesome! Thanks for your nice fix @myokoym 🚢

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#550
@tricknotes

I think all posts have public_id that is difference with id. Are there any reason why Post#id should be the same as Post#public_id?

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#551
@tricknotes

We discussed on chat about this topic. We decided name this order specification as scope and use it here. To specify order for pagination. To be m…

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#550
@tricknotes

We want to have some posts that have public_id different with id. How do you think about updating seed data? diff --git a/db/seeds/development/post…

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#551
@tricknotes

I think SerialsDecorator depends on PaginationInfoDecorator. ( https://github.com/bm-sms/daimon-news/pull/551/files#diff-f7ddda9786b3de2ac334a4bc6f…

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#551
@tricknotes

Can you create SerialsDecorator and move serials_page_title to it? The serials_page_title method doesn't use the attributes of Site, so this method…

Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#552
@tricknotes

26 is a magic number. I don't understand what this number means. Probably you want to show the second page of serials? If you want to do that, you …

tricknotes deleted branch update-ruby-versions at tchak/barber
Jun 23, 2016
Jun 23, 2016
@tricknotes
Jun 23, 2016
tricknotes merged pull request tchak/barber#58
@tricknotes
Update Ruby versions on Travis CI
1 commit with 5 additions and 5 deletions
Jun 23, 2016
tricknotes commented on pull request bm-sms/daimon-news#526
@tricknotes

review -> in progress

Something went wrong with that request. Please try again.