Post editing issues #585

Closed
vaniver opened this Issue Sep 29, 2016 · 6 comments

Projects

None yet

4 participants

@vaniver

It looks like lesswrong.com/submit gives a 404 when editing a post that's supposed to go to Main (with admin on). It's likely this is related to PR 575.

@jglamine

I'll take a look at this now.

@jglamine

I'm able to reproduce this locally.

Editing of articles is broken, both on main and discussion.
Submission to main works fine.

@jglamine

Found it.

The bug was caused by a JavaScript error. When the page loads, it tries to add some help text to the "url" filed. But on the edit page there is no "url" field. So it throws an exception and never binds the onSubmit handler for the form.

That's why it's posting to /submit instead of making an xhr request to /api/submit.

@jglamine jglamine added a commit to jglamine/lesswrong that referenced this issue Sep 29, 2016
@jglamine jglamine Only add help-text to url field if it exists. Fixes #585. 8ba4fec
@vipulnaik

I see you have a commit fixing the issue; but I still can't edit old posts. Is the commit just awaiting deployment, or is there more debugging you need to do?

@jglamine

Still waiting on deployment. I'd recommend watching PR #586 if you want to be notified when it's deployed.

@wezm wezm closed this in #586 Oct 4, 2016
@wezm
TrikeApps member

Fix deployed. Sorry about the delay we had a public holiday then I was off sick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment