Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Promoted posts in Discussion don't get into the overall LW RSS feed #593

Open
vaniver opened this Issue Nov 29, 2016 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

vaniver commented Nov 29, 2016

There are two acceptable ways to go about this, and it may require an investigation / rewrite of how the promotion mechanics work.

Options:

  1. Promoted posts in Main also show up in the list of posts in Discussion
  2. Promoted posts in Discussion also show up in this RSS feed

My guess is option 2 is easier.

Contributor

brendanlong commented Jan 21, 2017 edited

This is going to be tricky to do with Reddit's codebase. The way they do things is that every page is associated with some data, and if you add .rss to it, it gets rendered as XML (this trick also works with .json). So, anything that makes discussion posts show up in the main RSS feed will also make those posts show up on the main page.

You might be able be able to make this work by making the front page use a different controller than the promoted page in main.

For future reference, the code that looks up the list of links is in models/subreddit.py, various get_links() functions. The controller for the front page is currently BlessedController in controllers/listingcontroller.py, and I haven't traced the codebase far enough to know what's calling BlessedController (besides ListingController, obviously).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment