New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"search" Not respecting browser Search engines #333

Open
schmitmd opened this Issue Mar 8, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@schmitmd

schmitmd commented Mar 8, 2018

If I use "tabopen search" or "open search", it sends me straight to Google despite me having removed all search engines but DuckDuckGo in my browser settings.

If I type things into the address bar, tridactyl correctly uses DuckDuckGo.

If I can help diagnose/fix this somehow (without knowing anything in TypeScript or JavaScript), please let me know. Thanks!

@glacambre

This comment has been minimized.

Show comment
Hide comment
@glacambre

glacambre Mar 8, 2018

Member

We're already aware of this issue, unfortunately we can't do much about it for now: Mozilla doesn't give extensions access to the user's search engine preferences. If you wish to use DuckDuckGo instead of Google, you can use this command: :set searchengine duckduckgo. You can also create your own custom search engines using :searchsetkeyword myengine https://myengine.com/?q=.

This issue is frequently mentioned by users, even though we talk about it in the FAQ. In your opinion, what should be done in order to make finding information about this issue easier for new users?

Member

glacambre commented Mar 8, 2018

We're already aware of this issue, unfortunately we can't do much about it for now: Mozilla doesn't give extensions access to the user's search engine preferences. If you wish to use DuckDuckGo instead of Google, you can use this command: :set searchengine duckduckgo. You can also create your own custom search engines using :searchsetkeyword myengine https://myengine.com/?q=.

This issue is frequently mentioned by users, even though we talk about it in the FAQ. In your opinion, what should be done in order to make finding information about this issue easier for new users?

@schmitmd

This comment has been minimized.

Show comment
Hide comment
@schmitmd

schmitmd Mar 8, 2018

I'm very sorry! I must have either missed that in the FAQ or thought it was redundant (figured browser settings would be available to the extension). I definitely searched through the issues, but left on github's default "is:open" criteria, assuming that if it was still a problem, it would be an open, active issue. I now see #240 is the same thing.

I think, actually, leaving this (or a similar, with buzzwords like "Google," "default," etc.) issue open and flagging it Blocked pending whatever API additions (link goes here) are needed would be helpful. This might be a good way of catching people with useful info before they go creating duplicates of duplicates. That way, people know that it's an outstanding issue with a workaround (and they can subscribe for updates on progress).

schmitmd commented Mar 8, 2018

I'm very sorry! I must have either missed that in the FAQ or thought it was redundant (figured browser settings would be available to the extension). I definitely searched through the issues, but left on github's default "is:open" criteria, assuming that if it was still a problem, it would be an open, active issue. I now see #240 is the same thing.

I think, actually, leaving this (or a similar, with buzzwords like "Google," "default," etc.) issue open and flagging it Blocked pending whatever API additions (link goes here) are needed would be helpful. This might be a good way of catching people with useful info before they go creating duplicates of duplicates. That way, people know that it's an outstanding issue with a workaround (and they can subscribe for updates on progress).

@bovine3dom

This comment has been minimized.

Show comment
Hide comment
@bovine3dom

bovine3dom Mar 9, 2018

Member

#73 has been left open for that very reason.

Don't get your hopes up for this being fixed - Mozilla want to kill keywords eventually.

Member

bovine3dom commented Mar 9, 2018

#73 has been left open for that very reason.

Don't get your hopes up for this being fixed - Mozilla want to kill keywords eventually.

@cmcaine

This comment has been minimized.

Show comment
Hide comment
@cmcaine

cmcaine Mar 9, 2018

Member

Keyword seaches != browser search engines. Might as well leave this open.

Member

cmcaine commented Mar 9, 2018

Keyword seaches != browser search engines. Might as well leave this open.

@bovine3dom

This comment has been minimized.

Show comment
Hide comment
@bovine3dom

bovine3dom Mar 9, 2018

Member

Heh. One of the reasons Mozilla want to kill keywords is because they are confusing when they also have browser search engines. Confusion I just fell victim to. :(

Member

bovine3dom commented Mar 9, 2018

Heh. One of the reasons Mozilla want to kill keywords is because they are confusing when they also have browser search engines. Confusion I just fell victim to. :(

@HeidiSalami

This comment has been minimized.

Show comment
Hide comment
@HeidiSalami

HeidiSalami Apr 10, 2018

In your opinion, what should be done in order to make finding information about this issue easier for new users?

I read that part of the FAQ but though that was an option to add new engines. I did not get, that firefox search engine settings weren't used from that text.

HeidiSalami commented Apr 10, 2018

In your opinion, what should be done in order to make finding information about this issue easier for new users?

I read that part of the FAQ but though that was an option to add new engines. I did not get, that firefox search engine settings weren't used from that text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment