Scroll position when going back in history is sometimes not correctly restored

[e00E]

In Firefox when the normal behavior when going back in history (by pressing the back button or the back hotkey) is to restore the previous scroll position on the page. For example if I scroll halfway down a page, follow a link and press back my scroll position is again halfway down the page.

When Tridactyl is enabled this works inconsistently. Sometimes the correct scroll position is restored. Sometimes the scroll position is always at the top. Sometimes it is a seemingly random position.

[e00E]

The bug is not specific to going back, going forward in history has the same problem.

[e00E]

I am using Tridactyl's current Firefox version 1.13.1 and the current stable Firefox 61.0.1.

[glacambre]

Hi, thanks for opening this issue :)
Could you give us urls on which you can reproduce this bug?

[e00E]

The behavior is inconsistent. I have reproduced it at least once with with the main url of this repository for example https://github.com/cmcaine/tridactyl .

[glacambre]

Then this is most probably caused by https://github.com/cmcaine/tridactyl/blob/6ed83eacdbdd452f930e971993c7a7bbaccdfed2/src/excmds.ts#L589-L593

Not sure how to fix this :/