Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Updated TODOs.

  • Loading branch information...
commit 3a85c6583e9a767f7fba4d3904a4547f78da1c44 1 parent 2ce5d7f
@eriksoe eriksoe authored
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/protobuffs_generic.erl
View
4 src/protobuffs_generic.erl
@@ -137,8 +137,6 @@ decode(_MsgSpec={PBSpec,MsgIndex}, Bin, RecordInfoFun) ->
%%====
decode_msg(PBSpec, _MsgTypeSpec={MsgName,_}, <<>>, Acc, RecordInfoFun) ->
- %% TODO: Verify that required fields are present.
- %% TODO: Collect repeated fields.
to_record(get_record_info(RecordInfoFun, MsgName, PBSpec), Acc);
decode_msg(PBSpec, MsgTypeSpec={MsgName,FieldsSpec}, Bin, Acc, RecordInfoFun) ->
{ok, Tag} = protobuffs:next_field_num(Bin),
@@ -197,6 +195,8 @@ atomize(String) ->
to_record(RecordInfo, FieldList) ->
+ %% TODO: Verify that required fields are present?
+ %% TODO: Handle field defaults & empty 'repeated' fields.
case RecordInfo of
field_list ->
FieldList;
Please sign in to comment.
Something went wrong with that request. Please try again.