New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Trigger libraries pep8-compliant #212

Open
jathanism opened this Issue Apr 13, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@jathanism
Member

jathanism commented Apr 13, 2015

Sweep the codebase using flake8 and make everything pep8-tastic, and clean up any lingering cruft like documentation typo, unused imports and the like.

@coxley

This comment has been minimized.

Contributor

coxley commented Aug 21, 2015

Yikes. I may be up for tackling some of this tomorrow, it's pretty long overdue.

Fortunately once it's done, it'll make Trigger much friendlier to approach from the outside. Pretty code is good code.

@coxley

This comment has been minimized.

Contributor

coxley commented Aug 23, 2015

@jathanism: Do we still need the metadata (author, mnt, etc) at the header of several individual modules? They're all varying degrees of inaccurate, with one saying version 1.5.7?

I vote that it should be in one place for packaging.

@coxley

This comment has been minimized.

Contributor

coxley commented Aug 23, 2015

Man, some of these functions in twister take crazy long arg lists...

coxley added a commit to coxley/trigger that referenced this issue Aug 23, 2015

@jathanism

This comment has been minimized.

Member

jathanism commented Aug 24, 2015

Re top level attributions: those are per module. Since some of the modules and packages are complex they are internally versioned. Even if we ditched the version I feel that the author and maintainer definitions are important, so that we can more easily remember who has done what.

jathanism added a commit that referenced this issue Sep 10, 2015

Merge pull request #230 from coxley/pep8
#212: PEP8 compliance for twister module

@jathanism jathanism added 0 - Backlog and removed 1 - Ready labels Mar 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment