New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl_script is missing an import from trigger.acl.parser.Term #9

Closed
jathanism opened this Issue Apr 11, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@jathanism
Member

jathanism commented Apr 11, 2012

Traceback (most recent call last):
  File "/usr/local/bin/acl_script", line 530, in <module>
    opts.protocol)
  File "/usr/local/bin/acl_script", line 305, in create_trigger_term
    term = Term()
NameError: global name 'Term' is not defined

acl_script defines its own copy of create_trigger_term() and should just instead import it from trigger.acl.tools

@ghost ghost assigned jathanism Apr 11, 2012

@jathanism

This comment has been minimized.

Member

jathanism commented Apr 17, 2012

While we're in there, bin/acl_script and trigger.acl.tools.ACLScript have a lot of redundant code, and have circular dependencies upon each other. This should also be fixed.

@jathanism

This comment has been minimized.

Member

jathanism commented May 11, 2012

Fixed in 7f379d7

@jathanism jathanism closed this May 11, 2012

jathanism pushed a commit that referenced this issue Apr 1, 2014

Jathan McCollum
Merge pull request #9 from wrocha/bugfix-tacacsrc
TACACSRC multiline bug fix and unittests update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment