New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bounce window settings into configurable data vs. static module #10

Merged
merged 9 commits into from Dec 5, 2012

Conversation

Projects
None yet
1 participant
@jathanism
Member

jathanism commented Dec 5, 2012

Currently bounce windows within trigger.changemgmt are statically configured. They should be moved to a dynamic setup, database, or configuration file a la autoacl, netdevices.xml, settings.py.

@ghost ghost assigned jathanism Jun 15, 2012

jathanism added some commits Nov 29, 2012

Refactoring BounceWindow definition syntax to suck less
- Converted trigger.changemgmt into a package
- Prototype conversion code from old to new format found in bounce.py
- Next up: Loading the settings dynamically from /path/to/bounce.py
Release 1.2.4
+ The commands required to commit/save the configuration on a device
are now attached to NetDevice objects under the commit_commands
attribute, to make it easier to execute these commands without having
to determine them for yourself.
+ Added a way to optionally perform a "commit full" operation on
Juniper devices by defining a dictionary of attributes and values for
matching devices using settings.JUNIPER_FULL_COMMIT_FIELDS. This
modifies the commit_commands that are assigned when the NetDevice
object is created.
+ Console paging is now disabled by default for async SSH channels.
Merge branch 'master' into develop
Conflicts:
	AUTHORS.rst
fix #10: Overhaul change mgmt/bounce window internals
+ Bounce windows are no longer hard-coded in trigger.changemgmt and
  are now configured using bounce.py and specified using
  settings.BOUNCE_FILE. The interface for creating BounceWindow
  objects was greatly simplified to improve readability and usage.
+ New setting variables in settings.py:

  - BOUNCE_FILE - The location of the bounce window mapping
    definitions. Defaults to /etc/trigger/bounce.py.
  - BOUNCE_DEFAULT_TZ - Default timezone for bounce windows. Defaults
    to 'US/Eastern'
  - BOUNCE_DEFAULT_COLOR - The default bounce risk-level status color.
    Defaults to 'red'.

jathanism added a commit that referenced this pull request Dec 5, 2012

Merge pull request #10 from jathanism/develop
fix #10: Overhaul change mgmt/bounce window internals

+ Bounce windows are no longer hard-coded in trigger.changemgmt and
  are now configured using bounce.py and specified using
  settings.BOUNCE_FILE. The interface for creating BounceWindow
  objects was greatly simplified to improve readability and usage.
+ New setting variables in settings.py:

  - BOUNCE_FILE - The location of the bounce window mapping
    definitions. Defaults to /etc/trigger/bounce.py.
  - BOUNCE_DEFAULT_TZ - Default timezone for bounce windows. Defaults
    to 'US/Eastern'
  - BOUNCE_DEFAULT_COLOR - The default bounce risk-level status color.
    Defaults to 'red'.

@jathanism jathanism merged commit 2457326 into trigger:develop Dec 5, 2012

jathanism pushed a commit that referenced this pull request Apr 1, 2014

Jathan McCollum
Merge pull request #10 from nbabin/develop
Added check for HOME environment variable for acceptance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment