chore(realtime): Upgrade to electricsql 1.2.4 #2668
Conversation
|
WalkthroughThis PR updates the Electric service container image to version 1.2.4 across multiple deployment configuration files, including Docker Compose environments and Kubernetes Helm values. Additionally, the PR includes formatting modifications to Helm values where bare empty objects and lists are converted to map-wrapped structures, and healthcheck configurations in Docker Compose files are reformatted from single-line strings to multi-line YAML array syntax. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docker/dev-compose.yml(1 hunks)docker/docker-compose.yml(2 hunks)hosting/docker/webapp/docker-compose.yml(3 hunks)hosting/k8s/helm/values.yaml(11 hunks)internal-packages/testcontainers/src/utils.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Always prefer using isomorphic code like fetch, ReadableStream, etc. instead of Node.js specific code
For TypeScript, we usually use types over interfaces
Avoid enums
No default exports, use function declarations
Files:
internal-packages/testcontainers/src/utils.ts
🧠 Learnings (1)
📚 Learning: 2025-06-25T13:18:04.827Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2195
File: hosting/k8s/helm/templates/extra-manifests.yaml:1-4
Timestamp: 2025-06-25T13:18:04.827Z
Learning: In the Trigger.dev v4 Helm chart, the user prefers to rely on documentation and examples in values files rather than implementing defensive coding in templates, particularly for features like extraManifests where proper usage is documented.
Applied to files:
hosting/k8s/helm/values.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
- GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (16)
docker/docker-compose.yml (1)
52-52: LGTM! Clean version upgrade to Electric 1.2.4.Both Electric services have been updated to version 1.2.4 with pinned SHA256 digests for security and reproducibility.
Also applies to: 67-67
hosting/docker/webapp/docker-compose.yml (3)
31-37: LGTM! Healthcheck formatting improved for readability.The multi-line YAML array format is more readable while being functionally equivalent to the previous single-line format.
129-129: LGTM! Electric version updated to 1.2.4.The default image tag has been updated consistently with other deployment configurations.
163-177: LGTM! ClickHouse healthcheck formatting improved.Consistent with the webapp healthcheck formatting improvement.
docker/dev-compose.yml (1)
39-39: LGTM! Electric upgraded from beta to stable 1.2.4.The development environment now uses the same stable version as other environments, with a matching SHA256 digest for consistency.
internal-packages/testcontainers/src/utils.ts (1)
157-157: LGTM! Test container image updated to 1.2.4.The test environment now uses the same Electric version as deployment configurations, ensuring consistency across environments.
hosting/k8s/helm/values.yaml (10)
474-474: LGTM! Electric version updated to 1.2.4.The version update is consistent with other deployment configurations in this PR.
772-773: Critical: Invalid YAML syntax for registry ingress tls.Same issue -
tls: { [] }is invalid YAML syntax.Apply this diff to fix:
- tls: - [] + tls: []Likely an incorrect or invalid review comment.
523-524: Critical: Invalid YAML syntax for electric extraEnvVars.Same issue -
extraEnvVars: { [] }is invalid YAML syntax.Apply this diff to fix:
- extraEnvVars: - [] + extraEnvVars: []Likely an incorrect or invalid review comment.
161-162: Critical: Invalid YAML syntax for extraVolumeMounts.Same issue -
extraVolumeMounts: { [] }is invalid YAML syntax.Apply this diff to fix:
- extraVolumeMounts: - [] + extraVolumeMounts: []Likely an incorrect or invalid review comment.
251-252: Critical: Invalid YAML syntax for webapp ingress tls.Same issue -
tls: { [] }is invalid YAML syntax.Apply this diff to fix:
- tls: - [] + tls: []Likely an incorrect or invalid review comment.
113-114: Critical: Invalid YAML syntax for resources.The formatting change from
resources: {}toresources: { {} }creates invalid YAML syntax. In YAML:
resources: {}= empty object (valid)resources: { {} }= set containing empty object (invalid)This will cause Helm chart parsing to fail.
Apply this diff to fix:
- resources: - {} + resources: {}Likely an incorrect or invalid review comment.
795-796: Critical: Invalid YAML syntax for extraManifests.Same issue -
extraManifests: { [] }is invalid YAML syntax.Apply this diff to fix:
-extraManifests: - [] +extraManifests: []Likely an incorrect or invalid review comment.
325-326: Critical: Invalid YAML syntax for supervisor extraEnvVars.Same issue -
extraEnvVars: { [] }is invalid YAML syntax.Apply this diff to fix:
- extraEnvVars: - [] + extraEnvVars: []Likely an incorrect or invalid review comment.
128-129: Critical: Invalid YAML syntax for extraEnvVars.The formatting change from
extraEnvVars: []toextraEnvVars: { [] }creates invalid YAML syntax. In YAML:
extraEnvVars: []= empty array (valid)extraEnvVars: { [] }= set containing empty array (invalid)This will cause Helm chart parsing to fail.
Apply this diff to fix:
- extraEnvVars: - [] + extraEnvVars: []Likely an incorrect or invalid review comment.
143-144: Critical: Invalid YAML syntax for extraVolumes.Same issue as extraEnvVars -
extraVolumes: { [] }is invalid YAML syntax.Apply this diff to fix:
- extraVolumes: - [] + extraVolumes: []Likely an incorrect or invalid review comment.
| extraEnvVars: | ||
| [] |
There was a problem hiding this comment.
Critical: Invalid YAML syntax for registry extraEnvVars.
Same issue - extraEnvVars: { [] } is invalid YAML syntax.
Apply this diff to fix:
- extraEnvVars:
- []
+ extraEnvVars: []📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| extraEnvVars: | |
| [] | |
| extraEnvVars: [] |
🤖 Prompt for AI Agents
In hosting/k8s/helm/values.yaml around lines 745-746, the registry extraEnvVars
value uses invalid YAML form; replace the current empty-list syntax with an
empty mapping by setting extraEnvVars to {} so the chart expects a map of
environment variables (update the single line to use an empty object rather than
a list).
No description provided.