-
-
Notifications
You must be signed in to change notification settings - Fork 898
fix(react): prevent infinite useEffect when passing an array of tags to useRealtimeRunsWithTag #2705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): prevent infinite useEffect when passing an array of tags to useRealtimeRunsWithTag #2705
Conversation
…to useRealtimeRunsWithTag
🦋 Changeset detectedLatest commit: 3f0efbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis PR adds a changeset entry and implements a fix for preventing infinite useEffect loops in the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (30)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlreferences/realtime-hooks-test/.eslintrc.jsonis excluded by!references/**references/realtime-hooks-test/.gitignoreis excluded by!references/**references/realtime-hooks-test/README.mdis excluded by!references/**references/realtime-hooks-test/next.config.tsis excluded by!references/**references/realtime-hooks-test/package.jsonis excluded by!references/**references/realtime-hooks-test/postcss.config.mjsis excluded by!references/**references/realtime-hooks-test/public/.gitkeepis excluded by!references/**references/realtime-hooks-test/src/app/actions.tsis excluded by!references/**references/realtime-hooks-test/src/app/batch/[id]/page.tsxis excluded by!references/**references/realtime-hooks-test/src/app/globals.cssis excluded by!references/**references/realtime-hooks-test/src/app/layout.tsxis excluded by!references/**references/realtime-hooks-test/src/app/page.tsxis excluded by!references/**references/realtime-hooks-test/src/app/run-with-streams/[id]/page.tsxis excluded by!references/**references/realtime-hooks-test/src/app/run/[id]/page.tsxis excluded by!references/**references/realtime-hooks-test/src/app/runs-with-tag/[tag]/page.tsxis excluded by!references/**references/realtime-hooks-test/src/app/stream/[id]/page.tsxis excluded by!references/**references/realtime-hooks-test/src/components/batch-viewer.tsxis excluded by!references/**references/realtime-hooks-test/src/components/run-viewer.tsxis excluded by!references/**references/realtime-hooks-test/src/components/run-with-streams-viewer.tsxis excluded by!references/**references/realtime-hooks-test/src/components/runs-with-tag-viewer.tsxis excluded by!references/**references/realtime-hooks-test/src/components/stream-viewer.tsxis excluded by!references/**references/realtime-hooks-test/src/trigger/batch-task.tsis excluded by!references/**references/realtime-hooks-test/src/trigger/simple-task.tsis excluded by!references/**references/realtime-hooks-test/src/trigger/stream-task.tsis excluded by!references/**references/realtime-hooks-test/src/trigger/streams.tsis excluded by!references/**references/realtime-hooks-test/src/trigger/tagged-task.tsis excluded by!references/**references/realtime-hooks-test/tailwind.config.tsis excluded by!references/**references/realtime-hooks-test/trigger.config.tsis excluded by!references/**references/realtime-hooks-test/tsconfig.jsonis excluded by!references/**
📒 Files selected for processing (2)
.changeset/late-kings-smell.md(1 hunks)packages/react-hooks/src/hooks/useRealtime.ts(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
- GitHub Check: typecheck / typecheck
- GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.changeset/late-kings-smell.md (1)
1-5: LGTM!The changeset correctly documents this bug fix as a patch release with an accurate description.
fixes #2629