fix(webapp): paginate shared Vercel env var fetch in onboarding + pull#3879
Conversation
getVercelSharedEnvironmentVariables/...Values read only the first page (~25) of the shared env endpoint, silently dropping the rest. The shared endpoint (/v1/env) paginates with a next-cursor the SDK can't follow, so add a raw-fetch cursor walk (#fetchAllSharedEnvsRaw) that loads every page, via a new getVercelClientAndToken accessor. Onboarding and pullEnvVarsFromVercel already decrypt and save the shared values.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
WalkthroughThis PR refactors Vercel integration to obtain raw access tokens alongside SDK clients and implements custom HTTP pagination for shared environment variables. A new 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Parse the raw GET /v1/env page with a zod schema instead of an `as` cast, so a Vercel payload-shape change fails cleanly at the boundary rather than silently degrading to empty/partial imports. Addresses a CodeRabbit review comment.
Closes #3850