Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SSH keys #110

Open
baurmatt opened this Issue Sep 10, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@baurmatt
Copy link

baurmatt commented Sep 10, 2018

Please support SSH keys additional to login credentials. This is especially helpful for Gitlab Enterprise installations where every user cost money.

Thanks in advance!

@w00fz

This comment has been minimized.

Copy link
Member

w00fz commented Sep 12, 2018

I looked into supporting ssh keys but it is quite a bit more complicated than I anticipated.

The main problem is that executed git commands from PHP are not able to read the .ssh/config (IdentityFile). In order to do this it requires a good chunk of code to be rewritten, perhaps by tapping into symfony/process instead of using the exec method.

I am open for this but for a future version, not at this moment, sorry.

@fralau

This comment has been minimized.

Copy link

fralau commented Sep 22, 2018

Could this help?

https://packagist.org/packages/pagemachine/authorized-keys

I guess however, that would require generating a key pair for the app, and storing it. This would also require encrypting the private key, with some secret password (but this should not be so different than storing an ordinary ssh password securely and retrieving it).

@w00fz

This comment has been minimized.

Copy link
Member

w00fz commented Sep 23, 2018

Actually I did some extra digging and turns out i couldn’t get it working because my key had a passphrase. That’s what’s not supported as well as how I parse the urls.
With a no-password passphrase I will be able to add support for keys and I’m planning to do so. I did a quick testing on another project and works flawlessly!

I might not be able to add this on the next upcoming release but i will definitely look into adding support for it in the near future.

@OleVik

This comment has been minimized.

Copy link
Contributor

OleVik commented Oct 9, 2018

I would second key-auth, or at least configuration that can live alongside or supersede the global git-config. I'm getting into the habit of signing all commits, and so the global setting forces me to sign every change that GitSync captures -- which fails with a gpg: AllowSetForegroundWindow(6216) failed: Access is denied. gpg: signing failed: Card error gpg: signing failed: Card error error: gpg failed to sign the data fatal: failed to write commit object.

@w00fz w00fz added the enhancement label Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.