Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trilinos Framework: Improve ATS2 build #9270

Closed
jwillenbring opened this issue Jun 10, 2021 · 3 comments
Closed

Trilinos Framework: Improve ATS2 build #9270

jwillenbring opened this issue Jun 10, 2021 · 3 comments
Assignees
@fryeguy52
Labels
type: enhancement Issue is an enhancement, not a bug
Milestone
FY21 Q3 Testing B...

Comments

@jwillenbring
Copy link
Member

Enhancement

@trilinos/framework

We received the following request with regards to the ATDM ATS2 xl build:

Full ats2 with the xl compiler (at least on power 9) would be useful. Right now the Trilinos tests are not built or tested.

As discussed with @fryeguy52 the first step would be to fix the current build errors in the build, then the next step would be to evaluate what else needs to be turned on (likely it sounds like tests primarily).
@jwillenbring jwillenbring added the type: enhancement Issue is an enhancement, not a bug label Jun 10, 2021
@jwillenbring
Copy link
Member Author

Per @bartlettroscoe this request is obsolete. Closing.

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Jun 14, 2021 •
edited
Loading

@jwillenbring, does this mean we can get rid of all of the broken ats2 xl builds going the dashboard for the last 6 months?

@jwillenbring
Copy link
Member Author

@bartlettroscoe Possibly/probably. We are going to do some additional checking.

bartlettroscoe added a commit to jjellio/Trilinos that referenced this issue Jun 14, 2021
@bartlettroscoe
ats2: Comment out listing of long-broken XL builds (trilinos#9270, tr…
6ba83c3 
…ilinos#7376)

Commenting out these builds just avoids people running them with:

  ./ctest-s-local-test-driver.sh all

It does not impact what currently runs on jenkins and submits to CDash.  (No
sense beating a dead horse.)
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 19, 2021
Merge 'trilinos/Trilinos:develop' (2be37f2) into 'tcad-charon/Trilino…
d3e38ab 
…s:develop' (16c177b).

* trilinos-develop: (71 commits)
  Tpetra: Remove some output from the Bug7758 test
  MueLu Stratimikos adapter: Enable half precision for factory-style PLs
  Tpetra: remove some deprecated usage
  ROL: implement the apply function for Thyra Vector
  Piro: changes to ROL adapters comply with ROL changes
  Piro: bug-fix in Piro::NOX_Solver
  Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280).
  Ifpack2: cleaning up unused variables in tests.
  Ctest: Adding Amesos2/Belos tests
  Ctest: Stuff failing on ride that worked on ascicgpu
  Ctest: Enabling non-UVM Ifpack2 tests
  Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp.
  Disable support for Makefile.export.* files (trilinos#8498)
  Tpetra: remove unused variable (copied too many times when breaking up a function)
  ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376)
  Ifpack2: adding missing logic for new tests.
  Belos: writing tests for 'long double' and 'float128' ScalarType.
  STK: Snapshot 06-11-21 17:50
  Tpetra: remove comments that don't apply to HIP
  Tpetra: Use HIPSpace for HIPWrapperNode
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 19, 2021
Merge 'trilinos/Trilinos:develop' (2be37f2) into 'tcad-charon/Trilino…
19b4402 
…s:develop' (16c177b).

* trilinos-develop: (71 commits)
  Tpetra: Remove some output from the Bug7758 test
  MueLu Stratimikos adapter: Enable half precision for factory-style PLs
  Tpetra: remove some deprecated usage
  ROL: implement the apply function for Thyra Vector
  Piro: changes to ROL adapters comply with ROL changes
  Piro: bug-fix in Piro::NOX_Solver
  Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280).
  Ifpack2: cleaning up unused variables in tests.
  Ctest: Adding Amesos2/Belos tests
  Ctest: Stuff failing on ride that worked on ascicgpu
  Ctest: Enabling non-UVM Ifpack2 tests
  Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp.
  Disable support for Makefile.export.* files (trilinos#8498)
  Tpetra: remove unused variable (copied too many times when breaking up a function)
  ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376)
  Ifpack2: adding missing logic for new tests.
  Belos: writing tests for 'long double' and 'float128' ScalarType.
  STK: Snapshot 06-11-21 17:50
  Tpetra: remove comments that don't apply to HIP
  Tpetra: Use HIPSpace for HIPWrapperNode
  ...
seamill pushed a commit to seamill/Trilinos that referenced this issue Jul 28, 2021
Merge 'trilinos/Trilinos:develop' (ba3df3f) into 'EM-Plasma/Trilinos:…
c0d311f 
…develop' (7591b32).

* trilinos/develop: (77 commits)
  zoltan2:  fix memory leak when sizeof(SCOTCH_Num) == sizeof(lno_t) trilinos#9312
  Tpetra: Remove some output from the Bug7758 test
  MueLu Stratimikos adapter: Enable half precision for factory-style PLs
  Tpetra: remove some deprecated usage
  Fixed some deprecated code
  MueLu Thyra adapter: Allow construction of half precision operator
  ROL: implement the apply function for Thyra Vector
  Piro: changes to ROL adapters comply with ROL changes
  Piro: bug-fix in Piro::NOX_Solver
  MueLu: Print Scalar in MG Summary for high and extreme verbosity
  Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280).
  Ifpack2: cleaning up unused variables in tests.
  Ctest: Adding Amesos2/Belos tests
  Ctest: Stuff failing on ride that worked on ascicgpu
  Ctest: Enabling non-UVM Ifpack2 tests
  Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp.
  Disable support for Makefile.export.* files (trilinos#8498)
  Tpetra: remove unused variable (copied too many times when breaking up a function)
  ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376)
  Ifpack2: adding missing logic for new tests.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fryeguy52 fryeguy52

Labels
type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Milestone
FY21 Q3 Testing Build Mods and Adds
Development

No branches or pull requests
3 participants
@bartlettroscoe @jwillenbring @fryeguy52