Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ifpack2: build error when building unit tests #9280

Closed
ikalash opened this issue Jun 12, 2021 · 5 comments
Closed

Ifpack2: build error when building unit tests #9280

ikalash opened this issue Jun 12, 2021 · 5 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Ifpack2 type: bug The primary issue is a bug in Trilinos code or tests

Comments

@ikalash
Copy link
Contributor

ikalash commented Jun 12, 2021 •
edited
Loading

It appears a recent commit broke the build with Ifpack2 tests on and one of the extended scalar types (long double, float128). The error looks as follows:

/nightlyAlbanyTests/Results/Trilinos-extended-sts/packages/ifpack2/test/unit_tests/Ifpack2_UnitTestBlockTriDiContainerUtil.hpp:243:33: error: ‘class Ifpack2::BlockTriDiContainer<Tpetra::RowMatrix<long double, int, long long int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial> >, Ifpack2::BlockTriDiContainerDetails::ImplNotAvailTag>’ has no member named ‘createDefaultComputeParameters’
  243 |         T_bare->compute(T_bare->createDefaultComputeParameters());
      |                         ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/nightlyAlbanyTests/Results/Trilinos-extended-sts/packages/ifpack2/test/unit_tests/Ifpack2_UnitTestBlockTriDiContainerUtil.hpp:251:32: error: ‘class Ifpack2::BlockTriDiContainer<Tpetra::RowMatrix<long double, int, long long int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial> >, Ifpack2::BlockTriDiContainerDetails::ImplNotAvailTag>’ has no member named ‘createDefaultApplyParameters’
  251 |           auto input = T_bare->createDefaultApplyParameters();
      |                        ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/nightlyAlbanyTests/Results/Trilinos-extended-sts/packages/ifpack2/test/unit_tests/Ifpack2_UnitTestBlockTriDiContainerUtil.hpp:304:55: error: ‘class Ifpack2::BlockTriDiContainer<Tpetra::RowMatrix<long double, int, long long int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial> >, Ifpack2::BlockTriDiContainerDetails::ImplNotAvailTag>’ has no member named ‘createDefaultComputeParameters’
  304 |             T_bare_advanced->compute(T_bare_advanced->createDefaultComputeParameters());
      |                                      ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The attached log file has the entire error. Could someone please look into this?

@trilinos/ifpack2

make_err.txt
@ikalash ikalash added type: bug The primary issue is a bug in Trilinos code or tests pkg: Ifpack2 labels Jun 12, 2021
@ikalash
Copy link
Contributor Author

ikalash commented Jun 15, 2021

Any updates on this? It is related to #5729 .

@ikalash ikalash mentioned this issue Jun 15, 2021
Closed
ikalash pushed a commit that referenced this issue Jun 16, 2021
Ifpack2: disabling tests causing build errors with extended
4684373 
scalar types (see issue #9280).
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 19, 2021
Merge 'trilinos/Trilinos:develop' (2be37f2) into 'tcad-charon/Trilino…
d3e38ab 
…s:develop' (16c177b).

* trilinos-develop: (71 commits)
  Tpetra: Remove some output from the Bug7758 test
  MueLu Stratimikos adapter: Enable half precision for factory-style PLs
  Tpetra: remove some deprecated usage
  ROL: implement the apply function for Thyra Vector
  Piro: changes to ROL adapters comply with ROL changes
  Piro: bug-fix in Piro::NOX_Solver
  Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280).
  Ifpack2: cleaning up unused variables in tests.
  Ctest: Adding Amesos2/Belos tests
  Ctest: Stuff failing on ride that worked on ascicgpu
  Ctest: Enabling non-UVM Ifpack2 tests
  Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp.
  Disable support for Makefile.export.* files (trilinos#8498)
  Tpetra: remove unused variable (copied too many times when breaking up a function)
  ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376)
  Ifpack2: adding missing logic for new tests.
  Belos: writing tests for 'long double' and 'float128' ScalarType.
  STK: Snapshot 06-11-21 17:50
  Tpetra: remove comments that don't apply to HIP
  Tpetra: Use HIPSpace for HIPWrapperNode
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 19, 2021
Merge 'trilinos/Trilinos:develop' (2be37f2) into 'tcad-charon/Trilino…
19b4402 
…s:develop' (16c177b).

* trilinos-develop: (71 commits)
  Tpetra: Remove some output from the Bug7758 test
  MueLu Stratimikos adapter: Enable half precision for factory-style PLs
  Tpetra: remove some deprecated usage
  ROL: implement the apply function for Thyra Vector
  Piro: changes to ROL adapters comply with ROL changes
  Piro: bug-fix in Piro::NOX_Solver
  Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280).
  Ifpack2: cleaning up unused variables in tests.
  Ctest: Adding Amesos2/Belos tests
  Ctest: Stuff failing on ride that worked on ascicgpu
  Ctest: Enabling non-UVM Ifpack2 tests
  Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp.
  Disable support for Makefile.export.* files (trilinos#8498)
  Tpetra: remove unused variable (copied too many times when breaking up a function)
  ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376)
  Ifpack2: adding missing logic for new tests.
  Belos: writing tests for 'long double' and 'float128' ScalarType.
  STK: Snapshot 06-11-21 17:50
  Tpetra: remove comments that don't apply to HIP
  Tpetra: Use HIPSpace for HIPWrapperNode
  ...
@jhux2
Copy link
Member

jhux2 commented Jun 23, 2021

@ikalash Do you know approximately when this broke?

@ikalash
Copy link
Contributor Author

ikalash commented Jun 23, 2021

@jhux2: I believe it was the day I opened the issue. The issue name is not quite accurate - the problem actually happens with ETI=ON as well. I ended up turning off the problematic tests when the extended STs are enabled, but it may be good to investigate this nonetheless as it may be a symptom of some underlying issue.

@ikalash ikalash changed the title Ifpack2: build error when building tests + ETI=OFF Ifpack2: build error when building unit tests Jun 23, 2021
seamill pushed a commit to seamill/Trilinos that referenced this issue Jul 28, 2021
Merge 'trilinos/Trilinos:develop' (ba3df3f) into 'EM-Plasma/Trilinos:…
c0d311f 
…develop' (7591b32).

* trilinos/develop: (77 commits)
  zoltan2:  fix memory leak when sizeof(SCOTCH_Num) == sizeof(lno_t) trilinos#9312
  Tpetra: Remove some output from the Bug7758 test
  MueLu Stratimikos adapter: Enable half precision for factory-style PLs
  Tpetra: remove some deprecated usage
  Fixed some deprecated code
  MueLu Thyra adapter: Allow construction of half precision operator
  ROL: implement the apply function for Thyra Vector
  Piro: changes to ROL adapters comply with ROL changes
  Piro: bug-fix in Piro::NOX_Solver
  MueLu: Print Scalar in MG Summary for high and extreme verbosity
  Ifpack2: disabling tests causing build errors with extended scalar types (see issue trilinos#9280).
  Ifpack2: cleaning up unused variables in tests.
  Ctest: Adding Amesos2/Belos tests
  Ctest: Stuff failing on ride that worked on ascicgpu
  Ctest: Enabling non-UVM Ifpack2 tests
  Ifpack2: changing GO to the one in Tpetra_Details_DefaultTypes.hpp.
  Disable support for Makefile.export.* files (trilinos#8498)
  Tpetra: remove unused variable (copied too many times when breaking up a function)
  ats2: Comment out listing of long-broken XL builds (trilinos#9270, trilinos#7376)
  Ifpack2: adding missing logic for new tests.
  ...
@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jun 25, 2022
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Ifpack2 type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikalash @jhux2