Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort input file list #5559

Open
wants to merge 1 commit into
base: develop
from

Conversation

@bmwiedemann
Copy link

commented Jul 22, 2019

@trilinos/

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Sort input file list
so that variables_f.js builds in a reproducible way
in spite of indeterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.

This PR was done while working on reproducible builds for openSUSE.

@bmwiedemann bmwiedemann changed the base branch from master to develop Jul 22, 2019

@bmwiedemann bmwiedemann force-pushed the bmwiedemann:sort branch from b1b379f to 04113cb Jul 22, 2019

Sort input file list
so that variables_f.js builds in a reproducible way
in spite of indeterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.

@bmwiedemann bmwiedemann force-pushed the bmwiedemann:sort branch from 04113cb to 26e978b Jul 22, 2019

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jul 22, 2019

WIP: I need to run another round of testing on this.

@trilinos-autotester

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@mhoemmen

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

@trilinos/framework

I don't think the pull request tests have a way to test these changes. They look fine to me, but we would need reproduction instructions in order to evaluate them.

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jul 22, 2019

My test looked good.

One way to reproduce the original issue is to build on 2 different ext4 filesystems with dir_index enabled (is default on). This caused variations in search/variables_f.js files.
Another way to trigger it, would be to use the 'disorderfs' FUSE filesystem to randomize readdir order in the build dir.

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jul 22, 2019

Here is a snippet from a diff, but due to the random input, you will get different diffs.

+++ new//usr/share/doc/packages/trilinos-doc/packages/xpetra/doc/html/search/variables_f.js     2019-07-05 12:00:00.000000000 +0000
@@ -1,6 +1,4 @@
 var searchData=
 [
-  ['rangemaps_5f',['rangemaps_',['../classXpetra_1_1BlockedCrsMatrix.html#a20e4a341fac502c3d2c02c7a50d9c66b',1,'Xpetra::BlockedCrsMatrix']]],
-  ['right_5fside',['RIGHT_SIDE',['/home/abuild/rpmbuild/BUILD/Trilinos-trilinos-release-12-10-1/packages/xpetra/doc/../../../packages/teuchos/doc/html/namespaceTeuchos.html#a4d69c405faef2b64ef0583adadcdbf91af01e44b3bfce7cb55b7537f0b1e23bde',1,'Teuchos']]],
-  ['rowmap_5f',['rowMap_',['../classXpetra_1_1MatrixView.html#ab578ce61f1c75bb636b3431fd8390db1',1,'Xpetra::MatrixView']]]
+  ['thyramaps_5f',['thyraMaps_',['../classXpetra_1_1MapExtractor.html#a6c2728225e6db2f419856c5138be7ce7',1,'Xpetra::MapExtractor']]]

bmwiedemann added a commit to bmwiedemann/theunreproduciblepackage that referenced this pull request Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.