Sort input file list #5559
Sort input file list #5559
Conversation
bmwiedemann
force-pushed
the
sort
branch
2 times, most recently
from
04113cb
to
26e978b
Compare
|
WIP: I need to run another round of testing on this. |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
@trilinos/framework I don't think the pull request tests have a way to test these changes. They look fine to me, but we would need reproduction instructions in order to evaluate them. |
|
My test looked good. One way to reproduce the original issue is to build on 2 different ext4 filesystems with dir_index enabled (is default on). This caused variations in search/variables_f.js files. |
|
Here is a snippet from a diff, but due to the random input, you will get different diffs. +++ new//usr/share/doc/packages/trilinos-doc/packages/xpetra/doc/html/search/variables_f.js 2019-07-05 12:00:00.000000000 +0000
@@ -1,6 +1,4 @@
var searchData=
[
- ['rangemaps_5f',['rangemaps_',['../classXpetra_1_1BlockedCrsMatrix.html#a20e4a341fac502c3d2c02c7a50d9c66b',1,'Xpetra::BlockedCrsMatrix']]],
- ['right_5fside',['RIGHT_SIDE',['/home/abuild/rpmbuild/BUILD/Trilinos-trilinos-release-12-10-1/packages/xpetra/doc/../../../packages/teuchos/doc/html/namespaceTeuchos.html#a4d69c405faef2b64ef0583adadcdbf91af01e44b3bfce7cb55b7537f0b1e23bde',1,'Teuchos']]],
- ['rowmap_5f',['rowMap_',['../classXpetra_1_1MatrixView.html#ab578ce61f1c75bb636b3431fd8390db1',1,'Xpetra::MatrixView']]]
+ ['thyramaps_5f',['thyraMaps_',['../classXpetra_1_1MapExtractor.html#a6c2728225e6db2f419856c5138be7ce7',1,'Xpetra::MapExtractor']]] |
E.g. seen in trilinos/Trilinos#5559
so that variables_f.js builds in a reproducible way in spite of indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good. Fixes trilinos#5559
bmwiedemann
force-pushed
the
sort
branch
2 times, most recently
from
5e77a89
to
d7ed884
Compare
so that variables_f.js builds in a reproducible way in spite of indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good. Fixes trilinos#5559
so that variables_f.js builds in a reproducible way in spite of indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good. Fixes trilinos#5559
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
I would still like to see this merged. Can I help anything more? |
|
@mhoemmen, were you wanting documentation in the diff of this PR, or were @bmwiedemann's comments above sufficient? |
|
This looks ok, but I have to ask
|
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jmgate ]! |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: bmwiedemann |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jmgate ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
@trilinos/framework, who owns the |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
1 similar comment
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
@jmgate It's all good, as long as y'all think this is harmless. Thanks! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
1 similar comment
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
@trilinos/
Sort input file list
so that variables_f.js builds in a reproducible way
in spite of indeterministic filesystem readdir order.
See https://reproducible-builds.org/ for why this is good.
This PR was done while working on reproducible builds for openSUSE.