Allow to override build date with SOURCE_DATE_EPOCH #7814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This date call is designed to work with all variants of date. Also use UTC to be independent of timezone. This PR was done while working on reproducible builds for openSUSE.
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
@bmwiedemann This should probably be opened in the Kokkos project, https://github.com/kokkos/kokkos, since Kokkos is snapshotted into Trilinos. |
|
Forwarded it to kokkos/kokkos#3327 |
|
@bmwiedemann @jhux2 |
|
Closing. |
|
We are removing the date. Btw. this wasn't affecting Trilinos anymore since January, since Makefile.kokkos was not used after the 3.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Allow to override build date with
SOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This date call is designed to work with all variants of date.
Also use UTC to be independent of timezone.
As an alternative, the date could be dropped to reduce complexity.
This PR was done while working on reproducible builds for openSUSE.
@trilinos/
Motivation
Stakeholder Feedback
Testing