diff --git a/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestMinimalFunctionality.java b/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestMinimalFunctionality.java index d3bb686f4f4d4..2b040c8907332 100644 --- a/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestMinimalFunctionality.java +++ b/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestMinimalFunctionality.java @@ -56,7 +56,7 @@ protected QueryRunner createQueryRunner() { kafka = TestingKafka.create(); kafka.start(); - pinot = new TestingPinotCluster(); + pinot = new TestingPinotCluster(kafka.getNetwork()); pinot.start(); kafka.createTopic(TOPIC_AND_TABLE); diff --git a/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestingPinotCluster.java b/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestingPinotCluster.java index 82e8e88e263b8..9852f408d0854 100644 --- a/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestingPinotCluster.java +++ b/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestingPinotCluster.java @@ -62,17 +62,17 @@ public class TestingPinotCluster private final GenericContainer zookeeper; private final HttpClient httpClient; - public TestingPinotCluster() + public TestingPinotCluster(Network network) { httpClient = new JettyHttpClient(); zookeeper = new GenericContainer<>(parse("zookeeper:3.5.6")) - .withNetwork(Network.SHARED) + .withNetwork(network) .withNetworkAliases(ZOOKEEPER_INTERNAL_HOST) .withEnv("ZOOKEEPER_CLIENT_PORT", String.valueOf(ZOOKEEPER_PORT)) .withExposedPorts(ZOOKEEPER_PORT); controller = new GenericContainer<>(parse(BASE_IMAGE)) - .withNetwork(Network.SHARED) + .withNetwork(network) .withClasspathResourceMapping("/pinot-controller", "/var/pinot/controller/config", BindMode.READ_ONLY) .withEnv("JAVA_OPTS", "-Xmx512m -Dlog4j2.configurationFile=/opt/pinot/conf/pinot-controller-log4j2.xml -Dplugins.dir=/opt/pinot/plugins") .withCommand("StartController", "-configFileName", "/var/pinot/controller/config/pinot-controller.conf") @@ -80,7 +80,7 @@ public TestingPinotCluster() .withExposedPorts(CONTROLLER_PORT); broker = new GenericContainer<>(parse(BASE_IMAGE)) - .withNetwork(Network.SHARED) + .withNetwork(network) .withClasspathResourceMapping("/pinot-broker", "/var/pinot/broker/config", BindMode.READ_ONLY) .withEnv("JAVA_OPTS", "-Xmx512m -Dlog4j2.configurationFile=/opt/pinot/conf/pinot-broker-log4j2.xml -Dplugins.dir=/opt/pinot/plugins") .withCommand("StartBroker", "-clusterName", "pinot", "-zkAddress", getZookeeperInternalHostPort(), "-configFileName", "/var/pinot/broker/config/pinot-broker.conf") @@ -88,7 +88,7 @@ public TestingPinotCluster() .withExposedPorts(BROKER_PORT); server = new GenericContainer<>(parse(BASE_IMAGE)) - .withNetwork(Network.SHARED) + .withNetwork(network) .withClasspathResourceMapping("/pinot-server", "/var/pinot/server/config", BindMode.READ_ONLY) .withEnv("JAVA_OPTS", "-Xmx512m -Dlog4j2.configurationFile=/opt/pinot/conf/pinot-server-log4j2.xml -Dplugins.dir=/opt/pinot/plugins") .withCommand("StartServer", "-clusterName", "pinot", "-zkAddress", getZookeeperInternalHostPort(), "-configFileName", "/var/pinot/server/config/pinot-server.conf") diff --git a/testing/trino-testing-kafka/src/main/java/io/trino/testing/kafka/TestingKafka.java b/testing/trino-testing-kafka/src/main/java/io/trino/testing/kafka/TestingKafka.java index 96efb832aa61e..43ca4f54b105a 100644 --- a/testing/trino-testing-kafka/src/main/java/io/trino/testing/kafka/TestingKafka.java +++ b/testing/trino-testing-kafka/src/main/java/io/trino/testing/kafka/TestingKafka.java @@ -60,6 +60,7 @@ public final class TestingKafka private static final DockerImageName KAFKA_IMAGE_NAME = DockerImageName.parse("confluentinc/cp-kafka"); private static final DockerImageName SCHEMA_REGISTRY_IMAGE_NAME = DockerImageName.parse("confluentinc/cp-schema-registry"); + private final Network network; private final KafkaContainer kafka; private final GenericContainer schemaRegistry; private final boolean withSchemaRegistry; @@ -83,11 +84,13 @@ public static TestingKafka createWithSchemaRegistry() private TestingKafka(String confluentPlatformVersion, boolean withSchemaRegistry) { this.withSchemaRegistry = withSchemaRegistry; + network = Network.newNetwork(); + closer.register(network::close); kafka = new KafkaContainer(KAFKA_IMAGE_NAME.withTag(confluentPlatformVersion)) - .withNetwork(Network.SHARED) + .withNetwork(network) .withNetworkAliases("kafka"); schemaRegistry = new GenericContainer<>(SCHEMA_REGISTRY_IMAGE_NAME.withTag(confluentPlatformVersion)) - .withNetwork(Network.SHARED) + .withNetwork(network) .withEnv("SCHEMA_REGISTRY_KAFKASTORE_BOOTSTRAP_SERVERS", "PLAINTEXT://kafka:9092") .withEnv("SCHEMA_REGISTRY_HOST_NAME", "0.0.0.0") .withEnv("SCHEMA_REGISTRY_LISTENERS", "http://0.0.0.0:" + SCHEMA_REGISTRY_PORT) @@ -238,4 +241,9 @@ public String getSchemaRegistryConnectString() { return "http://" + schemaRegistry.getContainerIpAddress() + ":" + schemaRegistry.getMappedPort(SCHEMA_REGISTRY_PORT); } + + public Network getNetwork() + { + return network; + } }