Disallow adding not null column when Delta Lake table is not empty #13785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Read timed out happened. I hope #13746 fixes the issue. |
|
The release note seems to be backwards? |
|
@electrum Thanks, fixed. |
findinpath
approved these changes
Aug 23, 2022
homar
approved these changes
Aug 23, 2022
| @@ -1153,7 +1153,7 @@ public void addColumn(ConnectorSession session, ConnectorTableHandle tableHandle | |||
| columnsBuilder.build(), | |||
| partitionColumns, | |||
| columnComments.buildOrThrow(), | |||
| columnNullability.buildOrThrow(), | |||
| columnsNullability.buildOrThrow(), | |||
There was a problem hiding this comment.
shouldn't this be a separate commit ?
There was a problem hiding this comment.
I think it's related: we allow adding NOT NULL for empty tables
(previously it was ignored)
i think it;s fine to keep as one commit
findepi
approved these changes
Aug 23, 2022
| @@ -1116,6 +1116,10 @@ public void addColumn(ConnectorSession session, ConnectorTableHandle tableHandle | |||
| DeltaLakeTableHandle handle = (DeltaLakeTableHandle) tableHandle; | |||
| checkSupportedWriterVersion(session, handle.getSchemaTableName()); | |||
|
|
|||
| if (!newColumnMetadata.isNullable() && !metastore.getValidDataFiles(handle.getSchemaTableName(), session).isEmpty()) { | |||
| throw new TrinoException(DELTA_LAKE_BAD_WRITE, format("Unable to add NOT NULL column '%s' for non empty table: %s.%s", newColumnMetadata.getName(), handle.getSchemaName(), handle.getTableName())); | |||
There was a problem hiding this comment.
IMO "non-empty" should be with a hyphen
| @@ -1153,7 +1153,7 @@ public void addColumn(ConnectorSession session, ConnectorTableHandle tableHandle | |||
| columnsBuilder.build(), | |||
| partitionColumns, | |||
| columnComments.buildOrThrow(), | |||
| columnNullability.buildOrThrow(), | |||
| columnsNullability.buildOrThrow(), | |||
There was a problem hiding this comment.
I think it's related: we allow adding NOT NULL for empty tables
(previously it was ignored)
i think it;s fine to keep as one commit
Additionally, stores the correct nullability when adding a new column. It was always nullable before this change.
ebyhr
force-pushed
the
ebi/delta-add-not-null-column
branch
from
26cf070
to
563391b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #13587
Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text: