Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate views in system.jdbc.tables #1488

Conversation

findepi
Copy link
Member

@findepi findepi commented Sep 10, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 10, 2019
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I agree we should have a test

@findepi findepi force-pushed the findepi/master/deduplicate-views-in-system-jdbc-tables-876222 branch from 70eb1d1 to 3c24bda Compare October 19, 2019 18:54
@findepi findepi force-pushed the findepi/master/deduplicate-views-in-system-jdbc-tables-876222 branch from 3c24bda to bb7dc3b Compare October 19, 2019 19:52
@findepi findepi merged commit 4306932 into trinodb:master Oct 20, 2019
@findepi findepi deleted the findepi/master/deduplicate-views-in-system-jdbc-tables-876222 branch October 20, 2019 17:46
@findepi findepi added this to the 323 milestone Oct 20, 2019
@findepi findepi mentioned this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants