Fix reading timestamptz before epoch from Parquet #12855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code applied `%` instead of `floorMod`, which isn't the correct conversion method for values before epoch.
findepi
force-pushed
the
findepi/iceberg-parquet-before-epoch
branch
from
a221280
to
30599a0
Compare
findepi
changed the title
ebyhr
approved these changes
Jun 15, 2022
hashhar
approved these changes
Jun 15, 2022
homar
approved these changes
Jun 15, 2022
|
Smoke test coverage for all connectors coming in #12864. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code applied
%instead offloorMod, which isn't the correctconversion method for values before epoch.
Fixes #12852
Extracted from #12795