Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trino 397 release notes #14194

Merged
merged 1 commit into from Sep 21, 2022
Merged

Add Trino 397 release notes #14194

merged 1 commit into from Sep 21, 2022

Conversation

colebow
Copy link
Member

@colebow colebow commented Sep 19, 2022

Description

Assemble the release notes for the upcoming Trino 397 release. Fixes #14154

Non-technical explanation

N/A

Release notes

(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Verification for each commit

Format: commit, committer/maintainer, PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion

15 September 2022 ✅

45eb8ef @arhimondr #14069 ✅ rn ✅ docs
3109aaf @arhimondr #14069 ✅ rn ✅ docs
9ae9444 @arhimondr #14069 ✅ rn ✅ docs
e1f688d @arhimondr #14069 ✅ rn ✅ docs

16 September 2022 ✅

1dc391a @findepi #14145 ✅ rn ✅ docs
315bcb0 @findepi #14158 ✅ rn ✅ docs
e9e5e11 @findepi #14125 ✅ rn ✅ docs
b88d183 @findepi #14125 ✅ rn ✅ docs
15dd728 @findepi #14118 ✅ rn ✅ docs
9f0ace6 @raunaqmorarka #14137 ✅ rn ✅ docs
cfc12aa @martint #14166 ✅ rn ✅ docs

17 September 2022 ✅

a7e8134 @findepi #14074 ✅ rn ✅ docs

18 September 2022 ✅

9a04fca @dain #14092 ✅ rn ✅ docs
08342e5 @dain #14092 ✅ rn ✅ docs
761ffbd @dain #14092 ✅ rn ✅ docs
2567afe @dain #14092 ✅ rn ✅ docs
0a0e628 @dain #14092 ✅ rn ✅ docs
aa225ae @dain #14092 ✅ rn ✅ docs
52eb874 @dain #14092 ✅ rn ✅ docs

19 September 2022 ✅

e8a1a79 @findepi #14171 ✅ rn ✅ docs
2c92f9f @findepi #14161 ✅ rn ✅ docs
a3d2c2f @findepi #14161 ✅ rn ✅ docs
8d70892 @findepi #14161 ✅ rn ✅ docs
c59633d @findepi #14179 ✅ rn ✅ docs
390f4c8 @findepi #14168 ✅ rn ✅ docs
9665ac6 @findepi #14188 ✅ rn ✅ docs
5dd95a9 @kokosing #14149 ✅ rn ✅ docs
30d642d @martint #13532 ✅ rn ✅ docs
b9b373c @martint #14182 ✅ rn ✅ docs
30d9b3c @findepi #14173 ✅ rn ✅ docs
59bb5fd @findepi #14173 ✅ rn ✅ docs
d6a7ba9 @findepi #14173 ✅ rn ✅ docs
147fe24 @findepi #14173 ✅ rn ✅ docs
e736d78 @findepi #14173 ✅ rn ✅ docs
18d875f @findepi #14173 ✅ rn ✅ docs
23c0eaf @findepi #14173 ✅ rn ✅ docs
c92c642 @findepi #14173 ✅ rn ✅ docs
ea9036f @findepi #14018 ✅ rn ✅ docs
47c1fb1 @findepi #14190 ✅ rn ✅ docs
79dc367 @findepi #13875 ✅ rn ✅ docs
c373dba @findepi #13875 ✅ rn ✅ docs
39e2ff2 @findepi #14079 ✅ rn ✅ docs
d562faf @findepi #14079 ✅ rn ✅ docs
6acfd82 @findepi #14079 ✅ rn ✅ docs
601a3a7 @findepi #13775 ✅ rn ✅ docs
d40b68c @findepi #14186 ✅ rn ✅ docs
22dd82d @findepi #14185 ✅ rn ✅ docs

20 September 2022

f2b212b @findepi #14193 ✅ rn ✅ docs
6a4f1ca @findepi #12349 ✅ rn ✅ docs
f10a1f9 @findepi #14187 ✅ rn ✅ docs
9485e42 @findepi #14187 ✅ rn ✅ docs
b0b5af1 @findepi #14207 ✅ rn ✅ docs
c16a430 @kokosing #14150 ✅ rn ✅ docs
faa3087 @findepi #14163 ✅ rn ✅ docs
b9b0485 @findepi #14192 ✅ rn ✅ docs
5ac5fdb @findepi #14192 ✅ rn ✅ docs
2b77883 @findepi #14077 ✅ rn ✅ docs
5e066e2 @Praveen2112 #14206 ✅ rn ✅ docs
e17dc3f @arhimondr #14040 ✅ rn ✅ docs

21 September 2022

ee753bf @Praveen2112 #13662 ✅ rn ✅ docs
e9dad2c @findepi #14223 ✅ rn ✅ docs
7dfd4f7 @findepi #14223 ✅ rn ✅ docs
8fe8a91 @findepi #14172 ✅ rn ✅ docs
ccfcb9d @kokosing #13490 ✅ rn ✅ docs
581842e @findepi #14198 ✅ rn ✅ docs
1115c56 @findepi #14234 ✅ rn ✅ docs

## General

* Fix incorrect parsing of invalid values in cast from `varchar` to `timestamp`. ({issue}`14164`)
* Fix potential incorrect results for queries where all data scanned from tables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what "potential" incorrect results is supposed to indicate ...

also dont know if we need to explain leaf stage and downstream more or somehow make this more consumable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to provide those details. If someone wants to find out more, they can look at the PR. However, the RN entry should explain the conditions under which the correctness issue might happen (type of queries, etc)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that this was the condition in which it happened. Let me try again with info from the PR, may need another suggestion/edit.

docs/src/main/sphinx/release/release-397.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
## General

* Fix incorrect parsing of invalid values in cast from `varchar` to `timestamp`. ({issue}`14164`)
* Fix potential incorrect results for queries where all data scanned from tables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to provide those details. If someone wants to find out more, they can look at the PR. However, the RN entry should explain the conditions under which the correctness issue might happen (type of queries, etc)

docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-397.md Outdated Show resolved Hide resolved
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@martint martint merged commit ecc5ea5 into trinodb:master Sep 21, 2022
@github-actions github-actions bot added this to the 397 milestone Sep 21, 2022
Comment on lines +51 to +52
* Fix potential table corruption when changing a table before committing to the
Hive metastore has completed. ({issue}`14118`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this wording doesn't convey the meaning.
It sounds like user "changing the table" could trigger the bug, while the triggering condition was e.g. network problems between Trino and HMS.

Any reason why the wording proposed in #14154 (comment) was not used here?
I checked PR comments of this PR (#14194), but didn't spot any related discussion that would explain this.

@colebow colebow deleted the colebow/rn-397 branch October 27, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Release notes for 397
5 participants