Add configurable application id to native filesystems #24361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/native-fs-app-id
branch
from
42a3e09 to
815e1dc
Compare
losipiuk
reviewed
Dec 4, 2024
lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsStorageFactory.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Dec 4, 2024
|
cc @electrum |
anusudarsan
approved these changes
Dec 4, 2024
|
can you add docs as well? |
wendigo
force-pushed
the
serafin/native-fs-app-id
branch
from
815e1dc to
3b5c4cf
Compare
|
@anusudarsan done |
|
@mosabua ptal at the docs |
mosabua
requested changes
Dec 4, 2024
wendigo
force-pushed
the
serafin/native-fs-app-id
branch
from
3b5c4cf to
7669d64
Compare
|
@mosabua ptal |
mosabua
reviewed
Dec 4, 2024
mosabua
reviewed
Dec 4, 2024
mosabua
reviewed
Dec 4, 2024
mosabua
approved these changes
Dec 4, 2024
wendigo
force-pushed
the
serafin/native-fs-app-id
branch
from
7669d64 to
4c5d8ba
Compare
electrum
approved these changes
Dec 4, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystemConfig.java
Outdated
Show resolved
Hide resolved
|
This is a good idea |
This can be used in the S3 audit log to identify the application accessing storage
wendigo
force-pushed
the
serafin/native-fs-app-id
branch
from
4c5d8ba to
816c317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24328
Adds
gcs.application-id,azure.application-idands3.application-idto the native fs configurations. This allows for additional identification of the application on the storage sideDescription
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: