Move FileFormatDataSourceStats to trino-plugin-toolkit module #24367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
hudi
SemionPar
approved these changes
Dec 4, 2024
mayankvadariya
force-pushed
the
mayank/move-stats-to-toolkit
branch
from
28e4276 to
316c42f
Compare
|
@raunaqmorarka tests are passing now. Please review. |
mayankvadariya
force-pushed
the
mayank/move-stats-to-toolkit
branch
from
316c42f to
4561a85
Compare
mayankvadariya
commented
Dec 4, 2024
| row("io.trino.plugin.hive.metastore.glue:name=delta,type=gluehivemetastore"), | ||
| row("io.trino.plugin.hive.metastore.glue:name=delta,type=gluemetastorestats"), | ||
| row("io.trino.plugin.hive:catalog=delta,name=delta,type=fileformatdatasourcestats"), | ||
| row("io.trino.plugin.base.metrics:catalog=delta,name=delta,type=fileformatdatasourcestats"), |
There was a problem hiding this comment.
this change wan't required for oss delta lake pt but observed that failure in parent PR. https://github.com/trinodb/trino/actions/runs/12152695165/job/33889755245?pr=24359#step:7:4193
raunaqmorarka
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparatory commit for #24117
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: