Remove deprecated SystemAccessControlFactory#create method
#24382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Dec 5, 2024
|
Ahah, this time revapi complains... |
Just over a year seems to be a long-enough transition period. The way this method was introduced forced the implementors of the interface to implement it even if the other, tracing-aware, version was implemented as well - but it was never called directly by the engine. This caused moderate chaos and confusion, resulting in versions which just returned `null`.
ksobolew
force-pushed
the
kudi/remove-obsolete-factory-method
branch
from
7574cbd to
dab90ee
Compare
ksobolew
commented
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just over a year seems to be a long-enough transition period. The way this method was introduced forced the implementors of the interface to implement it even if the other, tracing-aware, version was implemented as well - but it was never called directly by the engine. This caused moderate chaos and confusion, resulting in versions which just returned
null.Additional context and related issues
Deprecated in #18899.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: