Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 30, 2025

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Oct 30, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR increments Trino’s Java requirement to JDK 25.0.1 by bumping build properties, aligning the runtime check, and removing an obsolete compiler profile.

Entity relationship diagram for updated Java version properties in build configuration

erDiagram
    PROJECT_PROPERTIES {
        project_build_targetJdk int
        air_java_version string
    }
    PROJECT_PROPERTIES ||--|| VERSION : "uses"
    VERSION {
        version string
    }
Loading

Class diagram for updated TrinoSystemRequirements Java version check

classDiagram
    class TrinoSystemRequirements {
        +verifyJavaVersion()
    }
    class Version {
        +parse(String)
        +compareTo(Version)
    }
    TrinoSystemRequirements --> Version : uses
Loading

File-Level Changes

Change Details Files
Update build system Java version properties
  • Bump project.build.targetJdk from 24 to 25
  • Update air.java.version from 24.0.1 to 25.0.1
  • Synchronize .java-version file with new version
pom.xml
.java-version
Remove deprecated errorprone-compiler profile overrides
  • Delete profile-specific project.build.targetJdk property
  • Remove profile-specific air.java.version property
pom.xml
Align runtime Java check with new minimum
  • Change required Java version from 24.0.1 to 25.0.1 in system requirements
core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java

Possibly linked issues

  • #JDK 25 Adoption: The PR updates build configurations and system requirements to enforce JDK 25.0.1, directly addressing the issue's goal of adopting Java 25.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@wendigo wendigo changed the title Require JDK 25.0.1 to run Trino DONOTMERGE: Require JDK 25.0.1 to run Trino Oct 30, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wendigo wendigo force-pushed the serafin/jdk25-target branch 2 times, most recently from 1057412 to ff3843a Compare October 30, 2025 23:18
@wendigo wendigo changed the title DONOTMERGE: Require JDK 25.0.1 to run Trino Require JDK 25.0.1 to run Trino Oct 31, 2025
@wendigo wendigo requested a review from martint October 31, 2025 10:19
@wendigo wendigo force-pushed the serafin/jdk25-target branch from ff3843a to 391214a Compare October 31, 2025 10:20
@wendigo wendigo force-pushed the serafin/jdk25-target branch from 391214a to 35b95fd Compare October 31, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants