Improve 128-bit multiplication performance #9744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Oct 23, 2021
core/trino-spi/src/test/java/io/trino/spi/type/BenchmarkUnscaledDecimal128.java
Show resolved
Hide resolved
martint
force-pushed
the
decimal-multiply-perf
branch
from
a6aa058
to
0af9e52
Compare
skrzypo987
approved these changes
Oct 25, 2021
core/trino-spi/src/test/java/io/trino/spi/type/BenchmarkUnscaledDecimal128.java
Show resolved
Hide resolved
core/trino-spi/src/test/java/io/trino/spi/type/BenchmarkUnscaledDecimal128.java
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/type/UnscaledDecimal128Arithmetic.java
Show resolved
Hide resolved
lukasz-stec
approved these changes
Oct 25, 2021
core/trino-spi/src/main/java/io/trino/spi/type/UnscaledDecimal128Arithmetic.java
Outdated
Show resolved
Hide resolved
dain
reviewed
Oct 26, 2021
core/trino-spi/src/test/java/io/trino/spi/type/BenchmarkUnscaledDecimal128.java
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/type/UnscaledDecimal128Arithmetic.java
Show resolved
Hide resolved
dain
approved these changes
Oct 26, 2021
martint
force-pushed
the
decimal-multiply-perf
branch
2 times, most recently
from
deb52ce
to
c7e6b44
Compare
before BenchmarkUnscaledDecimal128.multiply128 avgt 60 10.258 ± 0.419 ns/op BenchmarkUnscaledDecimal128.multiplyLongInt avgt 60 7.894 ± 0.137 ns/op BenchmarkUnscaledDecimal128.multiplyLongLong avgt 60 8.038 ± 0.137 ns/op after BenchmarkUnscaledDecimal128.multiply128 avgt 60 8.048 ± 0.174 ns/op BenchmarkUnscaledDecimal128.multiplyLongInt avgt 60 5.171 ± 0.035 ns/op BenchmarkUnscaledDecimal128.multiplyLongLong avgt 60 5.381 ± 0.037 ns/op
martint
force-pushed
the
decimal-multiply-perf
branch
from
c7e6b44
to
6df0e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after