New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wifi-info capabilities #56

Merged
merged 1 commit into from Oct 6, 2018

Conversation

Projects
None yet
4 participants
@saoron
Contributor

saoron commented Oct 5, 2018

Description of the Change

iOS 12 added a new requirement if you need wifi info, this was discussed on #53

Why Should This Be In Core?

Would be great to have this out of the box since the purpose of this plugin is to use the wifi info

Possible Drawbacks

None

Applicable Issues

#53

Based on @msari-ipe-ext-1 suggestion, Thanks

@kalicki

This comment has been minimized.

Show comment
Hide comment
@kalicki

kalicki commented Oct 5, 2018

@jack828

This comment has been minimized.

Show comment
Hide comment
@jack828

jack828 Oct 6, 2018

Contributor

👍 we use this in production - I should've thought to make this PR 😅

Contributor

jack828 commented Oct 6, 2018

👍 we use this in production - I should've thought to make this PR 😅

@jack828

This comment has been minimized.

Show comment
Hide comment
@jack828

jack828 Oct 6, 2018

Contributor

I don't have write access though, so I can't merge, @tripflex will

Contributor

jack828 commented Oct 6, 2018

I don't have write access though, so I can't merge, @tripflex will

@tripflex

This comment has been minimized.

Show comment
Hide comment
@tripflex

tripflex Oct 6, 2018

Owner

@saoron thank you for submitting the PR @jack828 @kalicki I'm going to merge this based on you guys responses, as I have no way to test iOS stuff, so please let me know if you run into issues with this update

Owner

tripflex commented Oct 6, 2018

@saoron thank you for submitting the PR @jack828 @kalicki I'm going to merge this based on you guys responses, as I have no way to test iOS stuff, so please let me know if you run into issues with this update

@tripflex tripflex merged commit 4578a2d into tripflex:master Oct 6, 2018

@saoron saoron deleted the saoron:patch-1 branch Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment